feat: add example workflows #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharathkkb
approved these changes
Dec 22, 2020
README.md
Outdated
|
|
||
| - `Service Account User` - required to deploy to Cloud Run as service account | ||
|
|
||
| - `Storage Admin` - allow push to Google Container Registry |
There was a problem hiding this comment.
This is broad at the project level, perhaps we can link to further reading here for best practices of granting at the bucket level.
| on: | ||
| push: | ||
| branches-ignore: | ||
| - 'example-*' |
There was a problem hiding this comment.
Do we need to ignore these branches?
There was a problem hiding this comment.
I think it's nice that if someone is trying to run the example workflows it doesn't kick off this test workflow.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17