fix: improve archive performance (#101)

* fix: improve archive performance

* refactor zip tests

* check if ignores found

* remove fast-glob

package.json

@@ -34,7 +34,6 @@
     "@actions/core": "^1.4.0",
     "@types/archiver": "^5.1.0",
     "archiver": "^5.0.0",
-    "fast-glob": "^3.2.7",
     "fs": "0.0.1-security",
     "gaxios": "^4.3.0",
     "google-auth-library": "^6.0.6",

src/util.ts

@@ -20,7 +20,6 @@ import { Gaxios } from 'gaxios';
 import * as Archiver from 'archiver';
 import * as path from 'path';
 import ignore from 'ignore';
-import fg from 'fast-glob';
 
 /**
  * Zip a directory.
@@ -58,28 +57,25 @@ export async function zipDir(
       core.info(`function source zipfile created: ${archive.pointer()} bytes`);
     });
     archive.pipe(output);
-    // Add dir to root of archive
-    getFiles(dirPath).forEach((filepath) => {
-      archive.glob(filepath, {
-        cwd: dirPath,
-        noglobstar: true,
-      });
-    });
+
+    // gcloudignore
+    let gIgnoreF = undefined;
+    if (getGcloudIgnores(dirPath).length > 0) {
+      const gIgnore = ignore().add(getGcloudIgnores(dirPath));
+      gIgnoreF = function (
+        file: Archiver.EntryData,
+      ): false | Archiver.EntryData {
+        return !gIgnore.ignores(file.name) ? file : false;
+      };
+    }
+
+    // Add files in dir to archive iff file not ignored
+    archive.directory(dirPath, false, gIgnoreF);
     // Finish writing files
     archive.finalize();
   });
 }
 
-/**
- * @param dir dir to collect files from
- * @returns list of files that are not ignored
- */
-export function getFiles(dir: string): string[] {
-  const files = fg.sync(['**'], { cwd: dir });
-  // return list of files that are not ignored
-  return ignore().add(getGcloudIgnores(dir)).filter(files);
-}
-
 /**
  * @param dir dir which may contain .gcloudignore file
  * @returns list of ignores in .gcloudignore if present

tests/test-func-ignore-node/.gcloudignore

@@ -1 +1 @@
-node_modules/
+bar/

tests/test-func-ignore-node/bar/bar.txt

@@ -0,0 +1 @@
+test

tests/test-func-ignore-node/bar/baz/baz.txt

@@ -0,0 +1 @@
+test

tests/test-func-ignore/.gcloudignore

@@ -1 +1,2 @@
-*.txt
+*.txt
+.gcloudignore