Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve schema support #309

Merged
merged 17 commits into from May 8, 2024
Merged

Improve schema support #309

merged 17 commits into from May 8, 2024

Conversation

MarkDaoust
Copy link
Collaborator

@MarkDaoust MarkDaoust commented May 1, 2024 •
edited 

class Person(typing.TypedDict):
    name: str
    birthday: str
    favorite_food: str

m = genai.GenerativeModel(model_name="gemini-1.5-pro-latest")
result = m.generate_content(
     "describe a person",
    generation_config={
        "response_mime_type": "application/json",
        "response_schema": Person},
)

@MarkDaoust
handle nested schemas
c999e52 
Change-Id: I22476536eb12027eb6b3a6dfcfa95cf61d2f4c0c
@MarkDaoust
Improve support for nested schemas
b6785dd 
Change-Id: I51f761d87ab62465c50881301714aa5c38e7056d
@MarkDaoust
Improve support for nested schemas
5bb551e 
Change-Id: I4739d8c46b0815134d55fbff4413544cb71a39fe
@MarkDaoust
Improve support for nested schemas
f1d3648 
Change-Id: If97e7265954db092cfba54b0f61c1606d4b9b1d2
@MarkDaoust MarkDaoust marked this pull request as draft May 1, 2024 18:50
@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels May 1, 2024
@MarkDaoust
Improve support for nested schemas
7111db5 
Change-Id: I426db26133356eed885f7702ff2c465631adc418
@MarkDaoust
format
7391efa 
Change-Id: Id722f2a02b0115dfbdaafe5b9a9f56ad4c6737b1
@MarkDaoust
more tests that will need to pass
0cf9d4a 
Change-Id: I3595531b4c974a3bee0291abec470e625722dfb2
@MarkDaoust
work on nested schema.
bcea1ee 
Change-Id: Ia05084dd6e59009f6fca590c5a7e42b537964a51
@MarkDaoust
format
82b76d6 
Change-Id: I98cb8da98b0bb9aae7adcf073cd648b152410552
@MarkDaoust
Merge branch 'main' into nested-schema
3205c83 
Change-Id: Ic669469d4a08e5d881b20dd9495669adeb4e7014
@MarkDaoust
Merge branch 'main' into nested-schema
e6a10a7 
Change-Id: I357015d36c95b673501445d7595d34f5ea88087d
@MarkDaoust
service fails if 'required' is used in nested objects
7e3b174 
Change-Id: Iade8b6f91b2d26a29c90890a4b67678927f73a44
@MarkDaoust
format
b3d15fe 
Change-Id: Id6f123168f12657eb2c01f36aff848d717244554
@MarkDaoust MarkDaoust marked this pull request as ready for review May 6, 2024 23:14
@MarkDaoust MarkDaoust mentioned this pull request May 6, 2024
Merged
@MarkDaoust
Add support for types in "response_schema"
a144bde 
Change-Id: Id7a17d5fba055020bc9bd94d98bd585ed19171df
@MarkDaoust
add missing import
68292de 
Change-Id: Iacbcb1acbd468347ffb2b873258a1d0737c947d7
@MarkDaoust
update generativelanguage version
6372b9f 
Change-Id: I106cdf98a950ae6bf92dcf58c98064c09f5da5f4
@MarkDaoust
add tests
364956a 
Change-Id: I1de22340f48ed2d6ae54423419a33965a7bc3a67
@MarkDaoust MarkDaoust changed the title Nested schema support Improve schema support May 7, 2024
markmcd
markmcd approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@markmcd markmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@MarkDaoust MarkDaoust merged commit e09e7f2 into google-gemini:main May 8, 2024
7 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmcd markmcd markmcd approved these changes

Assignees
No one assigned
Labels
component:python sdk Issue/PR related to Python SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MarkDaoust @markmcd