Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict Harm category to the sublist only Gemini support #295

Merged
merged 9 commits into from May 17, 2024

Conversation

aertoria
Copy link
Contributor

@aertoria aertoria commented Apr 20, 2024

Description of the change

Fork safety_tpes and palm_safety_types

The combined HarmCategory enum makes everything worse. Can we split them?

Motivation

Create a subcategory of the list of harm category so that user will not confuse with the Palm ones.

Type of change

Choose one: Feature request

Checklist

  • I have performed a self-review of my code.
  • I have added detailed comments to my code where applicable.
  • I have verified that my change does not break existing code.
  • My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • I am familiar with the Google Style Guide for the language I have coded in.
  • I have read through the Contributing Guide and signed the Contributor License Agreement.

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels Apr 20, 2024
@MarkDaoust MarkDaoust marked this pull request as draft April 22, 2024 19:20
Change-Id: Ia69a22d341afbc1b029de1f61c0ac91886f40c8b
Change-Id: Ia94b262d4e27511ca2e4eeb02cb5bd617a772463
Change-Id: Ia1cb199148619ebbc26638d5983b435245904971
Change-Id: I2853a88d7acc51a78174c97e30bde8eb24e1d457
@MarkDaoust MarkDaoust marked this pull request as ready for review May 10, 2024 18:12
@MarkDaoust MarkDaoust merged commit 1b1d883 into google-gemini:main May 17, 2024
8 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:python sdk Issue/PR related to Python SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants