Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: feat: add Atlas description #25

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lvjonok
Copy link
Contributor

@lvjonok lvjonok commented Oct 3, 2023

This PR adds an Atlas description. I attempted to follow contribution guidelines, in README.md you can find notes on the process of converting URDF to MuJoCo.

What help I am needed:

  • licence: I have used URDF from drake project. So, probably the licence should be copied from there, but I am unaware.
  • textures: I have found another URDF description of Atlas which also contained textures and .dae files. My attempt was to use drake textures and add them to .xml using mapping (which .obj should use which textures) from .dae files. I have added an example of textures loading to utorso mesh because it will be more convenient to try for others.

@google-cla
Copy link

google-cla bot commented Oct 3, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@kevinzakka
Copy link
Collaborator

Regarding the license, it looks like it's a 3-clause BSD license so we can accept it. You can just copy paste that license verbatim.

@lvjonok
Copy link
Contributor Author

lvjonok commented Oct 13, 2023

Hello! When I could expect any further feedback or suggestions regarding textures mapping?

@yuvaltassa
Copy link
Collaborator

Hi, can you please clarify the issue with the textures?
I find the item in the OP regarding this issue quite unclear.

@lvjonok
Copy link
Contributor Author

lvjonok commented Oct 13, 2023

Hi, can you please clarify the issue with the textures? I find the item in the OP regarding this issue quite unclear.

In the original repository there are .DAE files with textures. I took as example utorso body and tried to apply textures I have found in .dae file.

  1. The first question I have is can I add two textures to one body? In the corresponding .dae file I see that it loads two .jpg files.
  2. The next question is how to actually understand parameters for the material component based on .dae file. Do I have to add some external parameters based on original mesh file?

That is why I have added the scene textures.xml which one can load and check that textures are loaded correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants