Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept a filter in the GET bookmarks endpoint #105

Merged
merged 3 commits into from May 13, 2024
Merged

Accept a filter in the GET bookmarks endpoint #105

merged 3 commits into from May 13, 2024

Conversation

pe1uca
Copy link
Contributor

@pe1uca pe1uca commented May 7, 2024

Handles #104

Copy logic from UI to filter API response.

grimoire/src/routes/+page.svelte

Line 54 in 7f92c7e

const searchedBookmarksIds = $searchEngine.search($searchedValue).map((b) => b.item.id);

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@goniszewski goniszewski added the enhancement New feature or request label May 13, 2024
@goniszewski goniszewski merged commit d1aaaae into goniszewski:main May 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goniszewski goniszewski goniszewski approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pe1uca @goniszewski