Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzzy search via search endpoint #104

Closed
pe1uca opened this issue May 6, 2024 · 2 comments
Closed

Fuzzy search via search endpoint #104

pe1uca opened this issue May 6, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@pe1uca
Copy link
Contributor

pe1uca commented May 6, 2024

Is your feature request related to a problem? Please describe.
I'd like to integrate grimoire with some search engines and search functionality of some apps via API.

Describe the solution you'd like
Implement a search_term parameter to have the exact same fuzzy search fuse.js provides to the UI.

A quicker option would be to make the url parameter do a fuzzy search instead of an exact one.

if (urlParam) {
const bookmark = await getBookmarkByUrl(urlParam, owner, locals.pb);
bookmarks = bookmark ? [bookmark] : [];

Describe alternatives you've considered

  • Leave the functionality to each service to pull the data and implement the search.

Additional context
https://docs.searxng.org/_modules/searx/engines/demo_online.html#request

@goniszewski goniszewski added enhancement New feature or request good first issue Good for newcomers labels May 9, 2024
@goniszewski
Copy link
Owner

Hello @pe1uca! Thank you for this great issue - it is very helpful, and I appreciate the additional details you provided.

I would like to keep Grimoire open to integration with external services, so this is a very good candidate to do so :)

@goniszewski
Copy link
Owner

Thank you for your contribution @pe1uca!

Your changes should be in latest in about ~30 mins. Nicely done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants