New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gopls/internal: add code action "extract declarations to new file" #479
base: master
Are you sure you want to change the base?
Conversation
d03849b
to
8c85d43
Compare
This PR (HEAD: 8c85d43) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/565895. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/565895. |
8c85d43
to
46ec4ff
Compare
Message from tricium-prod@appspot.gserviceaccount.com: Patch Set 1: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/565895. |
This PR (HEAD: 46ec4ff) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/565895. Important tips:
|
Message from tricium-prod@appspot.gserviceaccount.com: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/565895. |
Message from Chiawen Chen: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/565895. |
Message from Chiawen Chen: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/565895. |
Message from Chiawen Chen: Patch Set 2: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/565895. |
Message from Chiawen Chen: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/565895. |
Message from Alan Donovan: Patch Set 2: (13 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/565895. |
46ec4ff
to
da8e51f
Compare
This PR (HEAD: da8e51f) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/565895. Important tips:
|
Message from Chiawen Chen: Patch Set 2: (16 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/565895. |
Message from Alan Donovan: Patch Set 4: (39 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/565895. |
This code action moves selected code sections to a newly created file within the same package. The created filename is chosen as the first {function, type, const, var} name encountered. In addition, import declarations are added or removed as needed. Fixes golang/go#65707
da8e51f
to
fa8abe3
Compare
This PR (HEAD: fa8abe3) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/565895. Important tips:
|
Message from Chiawen Chen: Patch Set 4: (34 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/565895. |
This PR (HEAD: 549739f) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/565895. Important tips:
|
Message from Chiawen Chen: Patch Set 5: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/565895. |
Message from Alan Donovan: Patch Set 6: (37 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/565895. |
Message from Alan Donovan: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/565895. |
This code action moves selected code sections to a newly created file within the same package. The created filename is chosen as the first {function, type, const, var} name encountered. In addition, import declarations are added or removed as needed.
Fixes golang/go#65707