Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/bundle: add support for embedded generic structs #439

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

norbs57
Copy link

@norbs57 norbs57 commented Jun 13, 2023

The current implementation fails to rename field selectors that refer to embedded generic structs. This commit addresses this issue.

It also replaces calls to the deprecated io/ioutil package with calls to the os package, and there is a code simplification regarding a use of strings.Replace.

Fixes #60647

@gopherbot
Copy link
Contributor

This PR (HEAD: c49f84c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/502956 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/502956.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: a014f73) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/502956 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Alan Donovan:

Patch Set 2:

(4 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/502956.
After addressing review feedback, remember to publish your drafts!

The current implementation fails to rename field selectors that refer to embedded generic structs. This commit addresses this issue.

It also replaces calls to the deprecated io/ioutil package with calls to the os package, and there is a code simplification regarding a use of  `strings.Replace`.

Fixes #60647
@gopherbot
Copy link
Contributor

This PR (HEAD: 3a845c4) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/502956 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from tricium-prod@appspot.gserviceaccount.com:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/502956.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants