Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: trim HTTP or HTTPS Scheme from source code links #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

x/pkgsite: trim HTTP or HTTPS Scheme from source code links #13

wants to merge 1 commit into from
+34 −19

Conversation

nickel8448
Copy link
Contributor

A new template function is created, which trims the scheme of the URL.
Tests in server_test.go are modified accordingly.

Fixes golang/go#40943

x/pkgsite: trim HTTP or HTTPS Scheme from source code links
85c8144 
A new template function is created, which trims the scheme of the URL.
Tests in server_test.go are modified accordingly.

Fixes golang/go#40943
@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Oct 31, 2020
@nickel8448 nickel8448 mentioned this pull request Oct 31, 2020
Closed
@gopherbot
Copy link
Contributor

This PR (HEAD: 85c8144) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/pkgsite/+/266998 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@nickel8448
Copy link
Contributor Author

While reading through the code I found that several test cases were using sample.ModulePath for RepoUrl/RepositoryURL variables since this change makes ModulePath and RepoURL the same, I changed sample.ModulePath to sample.RepositoryURL wherever required. (Sample)

@gopherbot
Copy link
Contributor

Message from Jonathan Amsterdam:

Patch Set 1:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/266998.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jonathan Amsterdam:

Patch Set 1:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/266998.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
2 participants
@nickel8448 @gopherbot