New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime: Add Ice Lake and Sapphire Rapids ERMS support for memmove #66959
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: TangYang <yang.tang@intel.com>
This PR (HEAD: f3f5b0f) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/580735. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/580735. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/580735. |
Message from qiulaidongfeng: Patch Set 1: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/580735. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-04-22T10:39:48Z","revision":"d49514407921eb0754bda55d3aae8e71336c9fa2"} Please don’t reply on this GitHub thread. Visit golang.org/cl/580735. |
Message from qiulaidongfeng: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/580735. |
Message from Go LUCI: Patch Set 1: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/580735. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/580735. |
Message from Keith Randall: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/580735. |
Message from Martin Möhrmann: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/580735. |
Message from Martin Möhrmann: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/580735. |
Message from Alexander Yastrebov: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/580735. |
Message from Keith Randall: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/580735. |
Message from Martin Möhrmann: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/580735. |
Message from Mauri de Souza Meneguzzo: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/580735. |
Message from Dmitry Vyukov: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/580735. |
Message from Martin Möhrmann: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/580735. |
The current memmove implementation uses REP MOVSB to copy data larger than 2KB when the useAVXmemmove global variable is false and the CPU supports the ERMS feature.
This feature is currently only enabled on CPUs in the Sandy Bridge (Client), Sandy Bridge (Server), Ivy Bridge (Client), and Ivy Bridge (Server) microarchitectures.
For modern Intel CPU microarchitectures that support the ERMS feature, such as Ice Lake (Server), Sapphire Rapids , REP MOVSB achieves better performance than the AVX-based copy currently implemented in memmove.
Fixes #66958