New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto/rand: make Read not escape the byte slice #66801
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: a16041b) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/578516. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Mateusz Poliwczak: Patch Set 1: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
This PR (HEAD: 0654f22) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/578516. Important tips:
|
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-04-12T19:04:09Z","revision":"af8e49a2bd486cd303a3c8847c5bbf1c04115086"} Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Mateusz Poliwczak: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Mateusz Poliwczak: Patch Set 2: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-04-12T19:10:40Z","revision":"f70f54162b68f90ffa0eb5800d0ad6cae47f2da7"} Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
This PR (HEAD: f6234dc) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/578516. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Go LUCI: Patch Set 2: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-arm64 has failed with summary (view all results): FAILURE
Tests failed. See all test results. Error: Links: Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Mateusz Poliwczak: Patch Set 3: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-04-13T05:48:21Z","revision":"98c3ed463e44bd7a0424fce0c7c88571a281bdfa"} Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Mateusz Poliwczak: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Go LUCI: Patch Set 3: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-arm64 has failed with summary (view all results): FAILURE
Tests failed. See all test results. Error: Links: Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
This PR (HEAD: 81fe51c) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/578516. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 4: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Go LUCI: Patch Set 4: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-04-13T06:28:15Z","revision":"90bf2555ac1ed46fb151d2c60a4f710259db01b5"} Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Mateusz Poliwczak: Patch Set 4: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Go LUCI: Patch Set 4: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-amd64-boringcrypto has failed with summary (view all results): FAILURE
Tests failed. See all test results. Error: Links: Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Go LUCI: Patch Set 4: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
This PR (HEAD: c63aa96) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/578516. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 5: Commit-Queue+1 Run-TryBot+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Go LUCI: Patch Set 5: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-04-13T06:45:31Z","revision":"8105df94bbbdcea6c9dd12e1ab293424d4db61ee"} Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Gopher Robot: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Gopher Robot: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
This PR (HEAD: 423f7fe) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/578516. Important tips:
|
Message from Go LUCI: Patch Set 7: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Go LUCI: Patch Set 7: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Change-Id: Id2933260a99998fa7b5881a5ec73fae73a8a0056
This PR (HEAD: 3f77921) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/578516. Important tips:
|
Change-Id: I48001745916ed3dded163c48952277a88e546b24
Message from Mateusz Poliwczak: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
This PR (HEAD: f0094a8) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/578516. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 9: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Go LUCI: Patch Set 9: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-04-13T09:06:16Z","revision":"5c2bfcaae5740766a4d52a87d81b5ea4478220ac"} Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Go LUCI: Patch Set 9: LUCI-TryBot-Result-1 Copied votes on follow-up patch sets have been updated:
Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Go LUCI: Patch Set 10: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-04-13T09:06:41Z","revision":"59944e4cd5cbfd9dcfae179e430c771679905ddd"} Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Mateusz Poliwczak: Patch Set 10: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Go LUCI: Patch Set 10: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Go LUCI: Patch Set 10: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-04-13T09:09:39Z","revision":"59944e4cd5cbfd9dcfae179e430c771679905ddd"} Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Mateusz Poliwczak: Patch Set 10: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Go LUCI: Patch Set 10: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Go LUCI: Patch Set 10: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Change-Id: Ibd76a9eee139c278daf50db693c20a6e423a4973
This PR (HEAD: 1d9bc96) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/578516. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 11: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Go LUCI: Patch Set 11: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-04-13T17:14:57Z","revision":"d27f30ea2c1ef42fa1bb7ab8f47a4560bc4c9acc"} Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Mateusz Poliwczak: Patch Set 11: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Go LUCI: Patch Set 11: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Go LUCI: Patch Set 11: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Change-Id: I8ff1fe961bf1619a6dde85f079e8f195d29f5c2b
This PR (HEAD: bfdb438) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/578516. Important tips:
|
Message from Emmanuel Odeke: Patch Set 12: Run-TryBot+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Gopher Robot: Patch Set 12: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Gopher Robot: Patch Set 12: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
Message from Mateusz Poliwczak: Patch Set 12: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/578516. |
ReadAllocs-12 3.037µ ± 0% 2.877µ ± 0% -5.27% (p=0.000 n=25)
ReadAllocs-12 321.5Mi ± 0% 339.5Mi ± 0% +5.57% (p=0.000 n=25)
ReadAllocs-12 1.000Ki ± 0% 0.000Ki ± 0% -100.00% (p=0.000 n=25)
ReadAllocs-12 1.000 ± 0% 0.000 ± 0% -100.00% (p=0.000 n=25)
Fixes #66779