cmd/go: "go get" fails on import path patterns with wildcards ("...")

[FiloSottile]

The fix for cmd/go: remote command execution during "go get -u" (#29230) as released in Go 1.10.6 and 1.11.3 introduced a regression causing commands like go get example.com/... to fail with invalid import path: malformed import path "example.com/...": double dot when fetching packages not already present in GOPATH.

See #29236 (comment)

[niaow]

Looking through the code, I saw the following mistakes that could have caused this error:

Error 1 - strings.Contains(path, "..") creates false positives with something/...
8954add#diff-5b11f198c631a3d489e1be171853ab7bR40

Error 2 - the ... path would cause this to error too, since it is all .
8954add#diff-5b11f198c631a3d489e1be171853ab7bR70

Suggested Fix

Remove the check listed in error 1. In addition to causing false positives, it is rendered unnecessary by the line mentioned in error 2. Leave the line in error 2 unchanged, but add a check that skips this validation for the last element if it exactly matches ....

[niaow]

Is someone currently working on this? If not, I can try to create a fix.

[niaow]

In absence of a response, I have started fixing this.

[FiloSottile]

Thank you, but I believe @dmitshur and @bcmills are already moving on a fix.

[niaow]

Ok. Thank you for letting me know.