Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/gerritbot: leave a CL comment on a freshly imported PR to help confirm the author has a Gerrit account #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thepudds
Copy link
Contributor

@thepudds thepudds commented Jul 12, 2023

WIP. Quick & dirty draft for discussion purposes. (Builds, but otherwise
untested).

In discussion golang/go#61182, Bryan's list of friction around the
GitHub PR workflow includes:

"A significant fraction of GitHub PRs are abandoned when the author
does not respond to Gerrit comments, but the existence of an open
PR discourages other contributors from working on the corresponding
issue."

We attempt to partially mitigate that by adding an unresolved welcome
comment to Gerrit to provide some context to the PR author but also
to help a reviewer see if/when the author has registered for a Gerrit
account.

In the future, we could possibly also have a reminder or even
abandon the CL if the author never replies, but for now, those are
left as possible TODOs in the code.

Fixes golang/go#61316

@gopherbot
Copy link
Contributor

This PR (HEAD: 6d27e14) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/build/+/509135 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Heschi Kreinick:

Patch Set 1:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/509135.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 6d27e14) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/build/+/509135.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to register for Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from t hepudds:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/509135.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Heschi Kreinick:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/509135.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Heschi Kreinick:

Patch Set 1:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/509135.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from t hepudds:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/509135.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Heschi Kreinick:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/509135.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants