cmd/gerritbot: leave a CL comment on a freshly imported PR to help confirm the author has a Gerrit account #69
+56
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. Quick & dirty draft for discussion purposes. (Builds, but otherwise
untested).
In discussion golang/go#61182, Bryan's list of friction around the
GitHub PR workflow includes:
"A significant fraction of GitHub PRs are abandoned when the author
does not respond to Gerrit comments, but the existence of an open
PR discourages other contributors from working on the corresponding
issue."
We attempt to partially mitigate that by adding an unresolved welcome
comment to Gerrit to provide some context to the PR author but also
to help a reviewer see if/when the author has registered for a Gerrit
account.
In the future, we could possibly also have a reminder or even
abandon the CL if the author never replies, but for now, those are
left as possible TODOs in the code.
Fixes golang/go#61316