Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/gopherbot: change issue notification comment to include author name #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

cmd/gopherbot: change issue notification comment to include author name #10

wants to merge 2 commits into from
+5 −3

Conversation

kzisme
Copy link

@kzisme kzisme commented Aug 6, 2018 •
edited

@gopherbot
Copy link
Contributor

Message from Gerrit User 12446:

Uploaded patch set 2: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/127930.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 28643:

Patch Set 2: Code-Review+1

LGTM

Please don’t reply on this GitHub thread. Visit golang.org/cl/127930.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 5065:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/127930.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 5065:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/127930.
After addressing review feedback, remember to publish your drafts!

@kzisme kzisme changed the title x/build/cmd: Change issue notification comment to include author name. cmd/gopherbot: change issue notification comment to include author name Aug 6, 2018
@gopherbot
Copy link
Contributor

Message from Gerrit User 12446:

Uploaded patch set 3: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/127930.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 12446:

Uploaded patch set 4: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/127930.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 12446:

Uploaded patch set 5: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/127930.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 28622:

Patch Set 6:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/127930.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 28622:

Patch Set 6:

(1 comment)

Are there any other changes/tweaks I should be making to these commit(s)?

Please don’t reply on this GitHub thread. Visit golang.org/cl/127930.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 5065:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/127930.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 28962:

Patch Set 6:

(2 comments)

Patch Set 6:

(1 comment)

Are there any other changes/tweaks I should be making to these commit(s)?

Hey Kevin,

It seems like these two edits are still pending:

  1. Matching the messages on lines 834 and 844 to prevent dupes

  2. Editing the author name to line 844

Would you have time to make these edits?

Julie

Please don’t reply on this GitHub thread. Visit golang.org/cl/127930.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 28622:

Patch Set 7:

Patch Set 6:

(2 comments)

Patch Set 6:

(1 comment)

Are there any other changes/tweaks I should be making to these commit(s)?

Hey Kevin,

It seems like these two edits are still pending:

  1. Matching the messages on lines 834 and 844 to prevent dupes

  2. Editing the author name to line 844

Would you have time to make these edits?

Julie

Hey Julie,

Sorry for the slight delay.

I just pushed a few more changes - please let me know what you think.

Thanks,

Kevin

Please don’t reply on this GitHub thread. Visit golang.org/cl/127930.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Josh Bleecher Snyder:

Patch Set 7:

Ping. Anyone want to revive this? I'm excited to see authors in the notifications, and it'd be nice to get this submitted before anyone starts working on golang.org/issue/28839, to avoid unnecessary merge conflicts.

Please don’t reply on this GitHub thread. Visit golang.org/cl/127930.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Kevin Zita:

Patch Set 7:

Patch Set 7:

Ping. Anyone want to revive this? I'm excited to see authors in the notifications, and it'd be nice to get this submitted before anyone starts working on golang.org/issue/28839, to avoid unnecessary merge conflicts.

Hello Josh!

I'd be more than happy to take another look this weekend if someone can provide some feedback on the previous patch.

Cheers!

Please don’t reply on this GitHub thread. Visit golang.org/cl/127930.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Josh Bleecher Snyder:

Patch Set 7:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/127930.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 405e2fd) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/build/+/127930 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Kevin Zita:

Patch Set 9:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/127930.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Josh Bleecher Snyder:

Patch Set 9:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/127930.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 28643:

Patch Set 2: Code-Review+1

LGTM

Please don’t reply on this GitHub thread. Visit golang.org/cl/127930.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 5065:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/127930.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 5065:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/127930.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 28622:

Patch Set 6:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/127930.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 28622:

Patch Set 6:

(1 comment)

Are there any other changes/tweaks I should be making to these commit(s)?

Please don’t reply on this GitHub thread. Visit golang.org/cl/127930.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 5065:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/127930.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 28962:

Patch Set 6:

(2 comments)

Patch Set 6:

(1 comment)

Are there any other changes/tweaks I should be making to these commit(s)?

Hey Kevin,

It seems like these two edits are still pending:

  1. Matching the messages on lines 834 and 844 to prevent dupes

  2. Editing the author name to line 844

Would you have time to make these edits?

Julie

Please don’t reply on this GitHub thread. Visit golang.org/cl/127930.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 28622:

Patch Set 7:

Patch Set 6:

(2 comments)

Patch Set 6:

(1 comment)

Are there any other changes/tweaks I should be making to these commit(s)?

Hey Kevin,

It seems like these two edits are still pending:

  1. Matching the messages on lines 834 and 844 to prevent dupes

  2. Editing the author name to line 844

Would you have time to make these edits?

Julie

Hey Julie,

Sorry for the slight delay.

I just pushed a few more changes - please let me know what you think.

Thanks,

Kevin

Please don’t reply on this GitHub thread. Visit golang.org/cl/127930.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Josh Bleecher Snyder:

Patch Set 7:

Ping. Anyone want to revive this? I'm excited to see authors in the notifications, and it'd be nice to get this submitted before anyone starts working on golang.org/issue/28839, to avoid unnecessary merge conflicts.

Please don’t reply on this GitHub thread. Visit golang.org/cl/127930.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Kevin Zita:

Patch Set 7:

Patch Set 7:

Ping. Anyone want to revive this? I'm excited to see authors in the notifications, and it'd be nice to get this submitted before anyone starts working on golang.org/issue/28839, to avoid unnecessary merge conflicts.

Hello Josh!

I'd be more than happy to take another look this weekend if someone can provide some feedback on the previous patch.

Cheers!

Please don’t reply on this GitHub thread. Visit golang.org/cl/127930.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Josh Bleecher Snyder:

Patch Set 7:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/127930.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Kevin Zita:

Patch Set 9:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/127930.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Josh Bleecher Snyder:

Patch Set 9:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/127930.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
3 participants
@kzisme @gopherbot @googlebot