fix(spanner): Upgrade spanner client to latest, which adds JSON_VALUE support #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylechadha
changed the title
Pull Request Test Coverage Report for Build 1561731441
💛 - Coveralls |
walshie4
approved these changes
Dec 10, 2021
|
Is that build step needed? |
|
Created an issue to bump the visibility on this -- let me know if there's anything else I can do to get this shipped 🙏🏽 |
|
Hi @dhui apologies for the personal ping but any chance we could get this merged and a new build cut? Currently blocked on this -- let me know if there is anything I can do to help. Thank you 🙏🏽 |
nishantnathhoney
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update spanner library to latest, cloud.google.com/go/spanner@v1.28.0.
Specifically, our team is looking for JSON_VALUE support: googleapis/google-cloud-go#5173