Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ui test failure #20441

Merged
merged 1 commit into from
May 20, 2024
Merged

fix ui test failure #20441

merged 1 commit into from
May 20, 2024

Conversation

xuelichao
Copy link
Contributor

Thank you for contributing to Harbor!

fix ui test failure

Issue being fixed

Fixes #20440

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@xuelichao xuelichao requested a review from a team as a code owner May 17, 2024 07:24
@xuelichao xuelichao added the release-note/ignore-for-release Do not include PR or Issue for release notes label May 17, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.13%. Comparing base (b7b8847) to head (5a83489).
Report is 192 commits behind head on main.

Current head 5a83489 differs from pull request most recent head 58d575a

Please upload reports for the commit 58d575a to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20441      +/-   ##
==========================================
+ Coverage   67.56%   69.13%   +1.56%     
==========================================
  Files         991      795     -196     
  Lines      109181    99416    -9765     
  Branches     2719        0    -2719     
==========================================
- Hits        73768    68730    -5038     
+ Misses      31449    26948    -4501     
+ Partials     3964     3738     -226     
Flag Coverage Δ
unittests 69.13% <ø> (+1.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 323 files with indirect coverage changes

@zyyw
Copy link
Contributor

zyyw commented May 17, 2024

@xuelichao Could you please also help to cherry-pick it to this branch release-2.11.0?
We have cut a branch for v2.11.
Thanks

Signed-off-by: xuelichao <xuel@vmware.com>
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit be839e6 into goharbor:main May 20, 2024
20 checks passed
wy65701436 pushed a commit that referenced this pull request May 21, 2024
* fix ui test failure (#20441)

Signed-off-by: xuelichao <xuel@vmware.com>

* Fix-20459 Wrong sbom status displayed in UI

Signed-off-by: xuelichao <xuel@vmware.com>

---------

Signed-off-by: xuelichao <xuel@vmware.com>
Signed-off-by: Lichao Xue <68891670+xuelichao@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ignore-for-release Do not include PR or Issue for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the UI_UT of CI failed
7 participants