Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(.editorconfig): remove setting end_of_line and make Git track EOL changes on Windows #7725

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

jxshin
Copy link
Contributor

@jxshin jxshin commented Apr 15, 2024

…line changes on Windows

Describe the pull request

By default, Git automatically changes end_of_line between LF and CRLF.
In this case, when a file is opened in an editor with editorconfig on Windows, and then saved without any textual changes,
editorconfig will change end_of_line from CRLF to LF.
At the same time, Git will notice this change. You have to commit it or restore it.

Just let Git handle it, I suggest removing the setting of end_of_line in editorconfig.

Link to the issue: n/a"

Checklist

  • I agree to follow the Code of Conduct by submitting this pull request.
  • I have read and acknowledge the Contributing guide.
  • I have added test cases to cover the new code or have provided the test plan.

@jxshin jxshin requested a review from unknwon as a code owner April 15, 2024 13:15
@unknwon unknwon changed the title fix(.editorconfig): setting end_of_line as LF makes Git track end_of_… fix(.editorconfig): setting end_of_line as LF makes Git track end_of_line changes on Windows Apr 15, 2024
@unknwon unknwon changed the title fix(.editorconfig): setting end_of_line as LF makes Git track end_of_line changes on Windows fix(.editorconfig): setting end_of_line as LF makes Git track EOL changes on Windows Apr 15, 2024
@unknwon unknwon changed the title fix(.editorconfig): setting end_of_line as LF makes Git track EOL changes on Windows fix(.editorconfig): remove setting end_of_line and make Git track EOL changes on Windows Apr 15, 2024
Copy link
Member

@unknwon unknwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@unknwon unknwon merged commit 015589c into gogs:main Apr 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants