Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 5284 by making sure every opening tag gets closed in markdown #6622

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

idonov8
Copy link

@idonov8 idonov8 commented Sep 26, 2021

Fixes #5284

Turns out this is a really simple fix 馃榿

@idonov8 idonov8 changed the title fix issue 5284 by adding missing self closing tag WIP: fix issue 5284 by adding missing self closing tag Sep 26, 2021
@idonov8
Copy link
Author

idonov8 commented Sep 26, 2021

I was wrong. Working on it.

@idonov8 idonov8 changed the title WIP: fix issue 5284 by adding missing self closing tag Fix issue 5284 by making sure every opening tag gets closed Sep 30, 2021
@idonov8 idonov8 changed the title Fix issue 5284 by making sure every opening tag gets closed Fix issue 5284 by making sure every opening tag gets closed in markdown Nov 10, 2021
@unknwon
Copy link
Member

unknwon commented Dec 13, 2021

Close and re-opening the PR to trigger GitHub checks to run.

@unknwon unknwon closed this Dec 13, 2021
@unknwon unknwon reopened this Dec 13, 2021
@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #6622 (154681c) into main (fa3d011) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main   #6622      +/-   ##
========================================
- Coverage   8.84%   8.83%   -0.02%     
========================================
  Files         96      96              
  Lines      13194   13192       -2     
========================================
- Hits        1167    1165       -2     
+ Misses     11866   11865       -1     
- Partials     161     162       +1     

@unknwon
Copy link
Member

unknwon commented Dec 13, 2021

Thanks for the PR! Could you add some test cases to verify the case meant to be fixed will continue working?

@unknwon unknwon added the status: needs followup Need some extra work label Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs followup Need some extra work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown Tables are rendered below the footer
2 participants