Feature/input form field suffix prefix #242
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goetzrobin
requested changes
Apr 4, 2024
| @@ -4,7 +4,7 @@ import { cva, VariantProps } from 'class-variance-authority'; | |||
| import { ClassValue } from 'clsx'; | |||
|
|
|||
| export const inputVariants = cva( | |||
| 'flex rounded-md border font-normal border-input bg-transparent text-sm ring-offset-background file:border-0 file:text-foreground file:bg-transparent file:text-sm file:font-medium placeholder:text-muted-foreground focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-2 disabled:cursor-not-allowed disabled:opacity-50', | |||
| 'flex rounded-md border font-normal border-input bg-transparent text-sm ring-offset-background file:border-0 file:text-foreground file:bg-transparent file:text-sm file:font-medium placeholder:text-muted-foreground focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-ring disabled:cursor-not-allowed disabled:opacity-50', | |||
There was a problem hiding this comment.
I'm curious about the reason behind this change?
There was a problem hiding this comment.
when focused, it was adding a "double" ring around the input, which looks really bad when it has an error, or even when focused without an error
There was a problem hiding this comment.
Can you send me a screenshot of what you see? I am wondering if this is just how it looks with shadcn or if there's something wrong. Thank you!
| <div class="relative block {{ class }}"> | ||
| @if (hasPrefix) { | ||
| <div class="absolute left-4 top-0 flex h-10 items-center justify-center"> | ||
| <ng-content select="[hlmInputPrefix]"></ng-content> |
There was a problem hiding this comment.
Let's use self closing tags everywhere please
| standalone: true, | ||
| selector: 'hlm-input-form-field', | ||
| imports: [HlmInputDirective, HlmInputSuffixDirective, HlmInputPrefixDirective, HlmLabelDirective, NgClass], | ||
| templateUrl: './hlm-input-form-field.component.html', |
There was a problem hiding this comment.
Let's move the template into the component directly
|
@Rafik-Belkadi let me know if there's anything you need me to do to support you on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
guidelines: https://github.com/goetzrobin/spartan/blob/main/CONTRIBUTING.md#-commit-message-guidelines
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the new behavior?
Added ability to have prefix/suffix inside an input
Does this PR introduce a breaking change?