Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
guidelines: https://github.com/goetzrobin/spartan/blob/main/CONTRIBUTING.md#-commit-message-guidelines
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
Context can be found in Discord
What is the new behavior?
Does this PR introduce a breaking change?
Other information
As discussed in Discord, this fixes the issue of dynamically rendering columns using
@for
which caused errors in the underlying CdkTable.This is basically a complete rewrite of spartan's table by basically copying Angular Material's implementation and replacing the
mat
prefixes withbrn
andhlm
in their respective places and applying proper classes in thehlm
parts. I hope I didn't miss any classes.Usage is exactly like Angular Material's table.
One thing I'm not sure on is the mixed usage of
brn
andhlm
components in the final consuming code.My preference would be to have a
HlmTableComponent
that simply extends theBrnTableComponent
and just applies the same template and providers in its@Component
decorator plus some Tailwind classes, as I implemented - but I'm open to your suggestionsAnd in regards to the documentation I was thinking of copying parts of Materials table docs and for the example code applying on of the stories' code?
Left to do:
.template
files