You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The ufbx code does not use the bake_fps option. This is because the API takes p_bake_fps in the generate_scene function, but not append_from_file where it is needed.
If FBXDocument were a standalone class, we could change the API, but because it inherits from GLTFDocument, we can't change this API.
My recommendation is to add an extra bake_fps property in FBXState and assign this in the editor_scene_importer_ufbx. I'm not sure what to do about the bake_fps argument to generate_scene since it has no effect.
Steps to reproduce
Import an fbx with a 60 fps animation.
Select FBX2glTF and set fps to 60.
Look at the Animation. it will show extra keyframes:
Select ufbx and set fps to 60.
The animation will only have 30 frames per second. The same happens when using a FPS below 30 as well.
Minimal reproduction project (MRP)
I do not have any redistributable 60fps FBX file.
The text was updated successfully, but these errors were encountered:
Tested versions
Only in 4.3.dev
System information
Godot v4.3.dev (2efbc6b) - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3090 (NVIDIA; 31.0.15.3713) - Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz (16 Threads)
Issue description
The ufbx code does not use the
bake_fps
option. This is because the API takesp_bake_fps
in thegenerate_scene
function, but notappend_from_file
where it is needed.If FBXDocument were a standalone class, we could change the API, but because it inherits from GLTFDocument, we can't change this API.
My recommendation is to add an extra
bake_fps
property in FBXState and assign this in the editor_scene_importer_ufbx. I'm not sure what to do about thebake_fps
argument togenerate_scene
since it has no effect.Steps to reproduce
Import an fbx with a 60 fps animation.
Select FBX2glTF and set fps to 60.
Look at the Animation. it will show extra keyframes:
Select ufbx and set fps to 60.
The animation will only have 30 frames per second. The same happens when using a FPS below 30 as well.
Minimal reproduction project (MRP)
I do not have any redistributable 60fps FBX file.
The text was updated successfully, but these errors were encountered: