Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ufbx: bake_fps option in importer / FBXDocument api has no effect. #90888

Open
lyuma opened this issue Apr 19, 2024 · 0 comments
Open

ufbx: bake_fps option in importer / FBXDocument api has no effect. #90888

lyuma opened this issue Apr 19, 2024 · 0 comments

Comments

@lyuma
Copy link
Contributor

lyuma commented Apr 19, 2024

Tested versions

Only in 4.3.dev

System information

Godot v4.3.dev (2efbc6b) - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3090 (NVIDIA; 31.0.15.3713) - Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz (16 Threads)

Issue description

The ufbx code does not use the bake_fps option. This is because the API takes p_bake_fps in the generate_scene function, but not append_from_file where it is needed.

If FBXDocument were a standalone class, we could change the API, but because it inherits from GLTFDocument, we can't change this API.

My recommendation is to add an extra bake_fps property in FBXState and assign this in the editor_scene_importer_ufbx. I'm not sure what to do about the bake_fps argument to generate_scene since it has no effect.

Steps to reproduce

  1. Import an fbx with a 60 fps animation.

  2. Select FBX2glTF and set fps to 60.

  3. Look at the Animation. it will show extra keyframes:
    fbx2gltf_60fps

  4. Select ufbx and set fps to 60.

  5. The animation will only have 30 frames per second. The same happens when using a FPS below 30 as well.
    ufbx_60fps

Minimal reproduction project (MRP)

I do not have any redistributable 60fps FBX file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants