Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor shortcuts don't save #5373

Closed
rgrams opened this issue Jun 23, 2016 · 21 comments
Closed

Editor shortcuts don't save #5373

rgrams opened this issue Jun 23, 2016 · 21 comments

Comments

@rgrams
Copy link

rgrams commented Jun 23, 2016

Operating system or device - Godot version:
Windows 7. Recent 64-bit builds from https://archive.hugo.pro/godot/ and http://fixnum.org/godot/.

Issue description & repro steps:
Set or change any shortcut in the "Shortcuts" tab of the "Editor Settings" panel, yay, the shortcut works! Quit the editor and start it again; all the shortcuts are reset to the defaults. :(

@akien-mga akien-mga added this to the 2.1 milestone Jun 23, 2016
@djrm
Copy link
Contributor

djrm commented Jun 23, 2016

i thought i was the only one

@rgrams
Copy link
Author

rgrams commented Jul 3, 2016

I don't mean to nag, but is there a plan/timeline for fixing this? Not much point in having customizable shortcuts if they don't save.

@djrm
Copy link
Contributor

djrm commented Jul 3, 2016

@rgrams the plan is to fix this before 2.1 release

@rgrams
Copy link
Author

rgrams commented Jul 3, 2016

Random other editor settings have stopped saving in the last month-ish too: Script temperature history size, code complete delay . . .

@djrm
Copy link
Contributor

djrm commented Jul 3, 2016

I investigated this problem a bit and the values are saved correctly, the problem is when you reopen godot some saved values get overwritten (for instance the shortcuts)

@rgrams
Copy link
Author

rgrams commented Jul 3, 2016

Ahh! That sounds like it's the cause of #5477 too.

@allkhor
Copy link
Contributor

allkhor commented Jul 3, 2016

Android settings overwritten too, like a adb, jarsigner, debug keystore.
Os Xubuntu 16.04 x64, godot ac157f8 commit.

@djrm
Copy link
Contributor

djrm commented Jul 3, 2016

so it seems that its a general problem when loading project settings, at least certain settings.

@allkhor
Copy link
Contributor

allkhor commented Jul 3, 2016

Many settings after restart a godot overwritten to default value.

@djrm
Copy link
Contributor

djrm commented Jul 3, 2016

it seems that the problem of saving shortcuts is not related to other settings not being saved (which i haven't found any by the way).

djrm added a commit to djrm/godot that referenced this issue Jul 3, 2016
Pros:
 - shortcuts assigned by the user are now persistent
 - In case a shortcut is removed from code, user shortcuts remain the same (contrary to the current behavior were all the shortcuts will be removed)

Cons:
 - legacy shortcuts could pile up in the editor settings (not a big deal)
@djrm
Copy link
Contributor

djrm commented Jul 3, 2016

this was fixed by 1e095cf, i dont know about the other issues about missing settings but it might be possible that they are also fixed

@reduz
Copy link
Member

reduz commented Jul 3, 2016

they should be, so closing

@reduz reduz closed this as completed Jul 3, 2016
@rgrams
Copy link
Author

rgrams commented Jul 4, 2016

Woo! Sweet, it works.

@rgrams
Copy link
Author

rgrams commented Jul 5, 2016

Or . . . not. Now, about every other time I restart the editor I get this: screenshot, and all of the editor settings are lost, including the project list.

@allkhor
Copy link
Contributor

allkhor commented Jul 5, 2016

Maybe you try delete(rename|backup) your godot config folder? In linux a config location is: ~/.godot After that Godot create a new config and problem must be solved.

@djrm
Copy link
Contributor

djrm commented Jul 5, 2016

i dont know much about windows file paths but is it ok to mix this \ and this / in the same path, or to even use /.

as the terminal points out, the path to the config file contains both.

@rgrams
Copy link
Author

rgrams commented Jul 5, 2016

Ahhh, alright, deleting the config stuff seems to have solved the total settings wipe, thanks! Some random settings still resetting as before, but that's another issue.

@reduz
Copy link
Member

reduz commented Jul 6, 2016

@rgrams by chance you don't have that editor_setrings.tres that has an invalid identifier error right?

@reduz
Copy link
Member

reduz commented Jul 6, 2016

if any of you runs into this again please keep the file

@rgrams
Copy link
Author

rgrams commented Jul 6, 2016

@reduz here's the old .tres and .xml, though I haven't verified again if they're making it fail, it wasn't happening every time.
godot_editor settings files.zip

@reduz
Copy link
Member

reduz commented Jul 6, 2016

I don't see anything wrong with the tres and it seems to load it fine, I'll just leave closed but let me know if you experience something like that again (just post the broken .tres file)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants