Fix Query DryRun failures should return early with status codes #185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change brings Query dry-run exceptions (syntax errors, inaccessible tables, etc) closer to BigQuery behavior and adds test coverage.
Current behavior:
Test script with invalid query syntax, intended to trigger dry run exception:
When: Run against BigQuery (
BIGQUERY_EMULATOR_HOST
is undefined)Then: BigQuery correctly returns
Syntax error
exceptionWhen: Run against Emulator (
BIGQUERY_EMULATOR_HOST=http://localhost:9050
, branch ismain
)Then: Emulator incorrectly returns successful job and triggers callback
PR behavior:
When: Run against Emulator (
BIGQUERY_EMULATOR_HOST=http://localhost:9050
, branch isfix-query-dryrun-errors
)Then: Emulator correctly returns
Syntax error
exception)Closest equivalent tests for:
cloud.google.com/go/bigquery
:query_test.TestQuery()
cloud.google.bigquery
:tests/systems/test_query.py.test_dry_run()