Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Doc/update #7

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

WIP: Doc/update #7

wants to merge 3 commits into from

Conversation

hachi8833
Copy link
Member

Just to notify it is under construction of updating parser

@adlerhsieh
Copy link
Member

Thanks. I might not have time to go through PRs recently. If everything is working locally and documents are generated correctly, then it should be fine 👍

@hachi8833
Copy link
Member Author

@adlerhsieh Sorry, I have looked into retrieveMethodsFromNode, but it looks too complicated for me 😢
It might take more than half a month for the fix.
I'd be very glad if you'd fix the parser.

@adlerhsieh
Copy link
Member

Yeap, I'll check it when I got time. Thanks for reporting!

@hachi8833
Update retrieveMethodsFromNode
7ddc1ee 
Update commit id

Update for loops in retrieveMethodsFromNode()

Fix variable names

Extract FnName and FnLine

Parse comments, params, returns

Remove redundant for loop

Remove redundant for loop

Remove redundant for loop
@hachi8833
Copy link
Member Author

Finally updated retrieveMethodsFromNode().
Perhaps this should be working, but look like some api doc in Goby have been a bit inconsistent and needs fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hachi8833 @adlerhsieh