(BIDS-2841) Displaying amounts in the currency that the user selected #2770

thib-wien · 2023-12-13T12:28:07Z

Displaying amounts in the currency that the user selected (drop-down menu at the top right of the website). Before, this choice was ignored.

To the tester:
The currency selection is impossible when the explorer runs locally in its normal state (because price feeds do not exist, for example).
You will need to test this branch with a real network.

The ignored-currency bug has been corrected on many pages. Fixes for two other currency-related bugs that we found have been included too. The Ethereum version looks ready now.

The version for Gnosis needs to be discussed with an open mind: before the BIDS, some data were displayed in GNO (mainly the CL data) and other data in xDAI (EL data). With this BIDS, the user can select a fiat currency and the question is:

should we convert only xDAI amounts into fiat and leave GNO amounts untouched?
or should we convert all amounts (xDAI and GNO) into fiat?
or should we offer the users two drop-down menus, one for the CL and one for the EL?

If 1 is chosen, then why do some amounts remain in crypto whereas they are displayed in fiat with Ethereum?
I chose 2 for this BIDS, because it seems consistent with the desire of the user and what people experience with Ethereum. The users still have the possibility to see the GNO amounts of 1 when they select "GNO" in the drop-down.

==================================================

Displayed currencies for Ethereum as discussed with the product owner:

mempool:

Value in fiat
Gas Price in GWei

txs:

Value & Tx Fee in fiat

blocks:

Reward & Burned Fees in fiat
Base Fee in Gwei

/block/{block}#transactions:

Value, Tx Fee in fiat
Gas Price in Gwei

Eisei24

Please check the BIDS for an instruction on how to test this locally for an existing testnet.

One ETH value that was not yet changed but should be is the "Tx Reward" for the block/slot page, e.g. https://beaconcha.in/block/18784041

The tooltip behaviour was also discussed and it's fine that every value formatting we change for this BIDS shows the currency like the withdrawals, e.g. the linked block page "Tx Reward" currently doesn't show ETH in the tooltip but it should.

db/bigtable_eth1.go

…e very unclear to the beginner

…conversion everywhere

Eisei24

Please have a look at my comments.

Additionally I wonder about whether pages use $ or USD.
I think all the changed pages show USD now but e.g. the withdrawals tab of an address shows $ which is strange.
A validator page on mainnet already shows a wild mix, e.g.
https://beaconcha.in/validator/1017027#deposits (set to USD)
Is there a consensus for the behaviour?

handlers/slot.go

Eisei24 · 2024-01-03T12:48:58Z

templates/layout.html

issue: Just a reminder that the changes to this file have to be reverted after the review is done.

I think that we can keep this change to see the currency drop-down when the explorer runs locally. The price of ETH is then arbitrary ($2000).
I am not sure why this was deactivated for local tests.
What do you think?

Eisei24 · 2024-01-03T12:52:05Z

price/price.go

issue: Just a reminder that changes to this file have to be reverted after the review is done.

For now, I made theses changes clean and didn't remove them because I think that it is good to allow testers to select "USD" in the drop-down when the explorer runs locally. The price of ETH is then arbitrary ($2000).
What do you think?

Eisei24 · 2024-01-03T14:15:29Z

templates/slot/slot.html

@@ -455,7 +455,7 @@ <h3 class="h5 col-md-12 text-center"><b>Showing {{ .AttestationsCount }} Attesta
        {{ if .ExecutionData }}
          <div class="tab-pane fade" id="transactionsTabPanel" role="tabpanel" aria-labelledby="transactions-tab">
            <div class="card block-card py-1">
-              {{ template "execution_transactions" .ExecutionData }}


issue: We have this change in combination with

eth2-beaconchain-explorer/templates/slot/execTransactions.html

Line 2 in 281b32e

{{ with .Data.ExecutionData }}

to get the currency into execution_transactions but this is also called here

eth2-beaconchain-explorer/templates/execution/block.html

Line 130 in 91b2b05

{{ template "execution_transactions" . }}

for premerge blocks, e.g. Prater 7316000, and it cannot simply be adjusted since it has no ExecutionData part.
/block/7316000 currently crashes.

Fixed, I believe. Can you please check that it works? (I do not know how to connect my branch with Prater)

As discussed this doesn't work.

I hope it works now! I pray the god of BIDS2841 to stop bringing bugs

Unfortunately not, I still get the error
"...at <$data.ExecutionData>: can't evaluate field ExecutionData in type *types.Eth1BlockPageData""
when I try to open a block page for a premerge block.

Unfortunately not, I still get the error when I try to open a block page for a premerge block.

Fixed.
I learnt that the template engine of Go cannot test the existence of fields. So, instead, now the template tests the value of $.Active which is set to "blockchain" by Eth1Block() in eth1Block.go for post-merge pages, whereas it is set to "block" for pre-merge pages.
I find this solution dirty because these strings don't sound explicit and I am not sure that they are definitive. For now everything works.

Eisei24 · 2024-01-03T14:22:57Z

templates/slot/overview.html

@@ -56,7 +56,7 @@
          <div class="row border-bottom p-3 mx-0">
            <div class="col-md-2"><span data-toggle="tooltip" data-placement="top" title="Transaction rewards from block {{ .Number }}">Tx Reward:</span></div>
            <div class="col-md-10">
-              {{ formatAmount .Reward config.Frontend.ElCurrency 5 }}


issue: This is a fix for newer slots/blocks but does not change it for blocks premerge, e.g. Prater 7316000.
The page for those currently does not work, see the comment below, but the line that formats the value is around here

eth2-beaconchain-explorer/templates/execution/block.html

Line 67 in 91b2b05

{{ formatAmount .Reward config.Frontend.ElCurrency 5 }}

and is not changed.

Before you change it it should be clarified whether we even want that or if it should always remain ETH.

Fixed, I believe.
Besides the rewards, I also changed the currency for the tx fees and the burned fees. This is consistent with what Butta suggested (see the end of this post).
Can you please check that it works? (I do not know how to connect my branch with Prater)

utACK for this, I will have a look once premerge blocks work again.

reminder to check

utils/eth1.go

price/price.go

thib-wien · 2024-01-05T21:31:54Z

I wonder about whether pages use $ or USD. I think all the changed pages show USD now but e.g. the withdrawals tab of an address shows $ which is strange. A validator page on mainnet already shows a wild mix, e.g. https://beaconcha.in/validator/1017027#deposits (set to USD) Is there a consensus for the behaviour?

This was implemented before me. To try, now everything is changed to USD for consistency.
We will show the result to Butta and ask what he thinks.

thib-wien · 2024-01-15T08:46:06Z

This was implemented before me. To try, now everything is changed to USD for consistency. We will show the result to Butta and ask what he thinks.

@Eisei24 I asked Butta. We keep my change (USD, EUR, AUD, etc. everywhere / No $, € and so on).

Eisei24

Please fix the premerge blocks page.

One line that I noticed that still showed $ instead of USD is the "ETH Value" in the "Overview" on the address page, e.g. https://beaconcha.in/address/0xF82aC5937A20dC862F9bc0668779031E06000f17

Again I can't tell you if it should be left like it is.

local-deployment/network-params.json

thib-wien · 2024-01-16T15:23:02Z

One line that I noticed that still showed $ instead of USD is the "ETH Value" in the "Overview" on the address page, e.g. https://beaconcha.in/address/0xF82aC5937A20dC862F9bc0668779031E06000f17

Again I can't tell you if it should be left like it is.

True, this has been missed.
However these signs ($, €, ...) are displayed only in the upper part of this page so there is a form of consistency (upper part: signs for shortness, lower part: literals).

I think the goal of the BIDS has been reached: making the currency conversion work everywhere. ~~I will ask Butta whether the signs must absolutely be replaced by words here.~~ Butta thinks that we can leave it as it is.

Eisei24

The premerge blocks page still needs to be fixed and the desired gnosis behaviour needs to be discussed.

…default on Gnosis

thib-wien · 2024-01-23T09:50:05Z

The premerge blocks page still needs to be fixed and the desired gnosis behaviour needs to be discussed.

The page with pre-merge blocks is fixed :)
Regarding Gnosis, I did some improvements,. Now we need to get the opinion of someone who knows well the world of Gnosis.

…ocally

(BIDS-2841) First findings of ignored choice of currency

3b03a8c

Eisei24 requested changes Dec 14, 2023

View reviewed changes

db/bigtable_eth1.go Show resolved Hide resolved

thib-wien added 4 commits December 18, 2023 11:13

The naming of function trimAmount() and its parameters in eth1.go wer…

c1a31c1

…e very unclear to the beginner

now convertAndFormatWei() converts currencies

b349659

(BIDS-2841) Corrects 2 pre-existing bugs and implements the currency …

8fb3892

…conversion everywhere

(BIDS-2841) Prettier

281b32e

Eisei24 requested changes Jan 3, 2024

View reviewed changes

thib-wien added 2 commits January 5, 2024 22:34

(BIDS-2841) Important fixes

9084488

(BIDS-2841) Clean up of the code

ab5553c

Eisei24 requested changes Jan 16, 2024

View reviewed changes

(BIDS-2604) Correction for pre-merge blocks?

e2cff33

thib-wien commented Jan 16, 2024

View reviewed changes

local-deployment/network-params.json Outdated Show resolved Hide resolved

(BIDS-2841) fiddling with starting code to simulate Gnosis

068e969

Eisei24 requested changes Jan 19, 2024

View reviewed changes

(BIDS-2841) fixes bug on premerge blocks for Ethereum + sets xDAI by …

34f9237

…default on Gnosis

(BIDS-2841) cleaning temporary changes which were necessary to test l…

971d427

…ocally

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(BIDS-2841) Displaying amounts in the currency that the user selected #2770

(BIDS-2841) Displaying amounts in the currency that the user selected #2770

thib-wien commented Dec 13, 2023 •

edited

Eisei24 left a comment

Eisei24 left a comment

Eisei24 Jan 3, 2024

thib-wien Jan 23, 2024 •

edited

Eisei24 Jan 3, 2024

thib-wien Jan 23, 2024

Eisei24 Jan 3, 2024

thib-wien Jan 5, 2024

Eisei24 Jan 16, 2024

thib-wien Jan 16, 2024

Eisei24 Jan 19, 2024

thib-wien Jan 22, 2024 •

edited

Eisei24 Jan 3, 2024

thib-wien Jan 5, 2024 •

edited

Eisei24 Jan 16, 2024

thib-wien Jan 16, 2024

thib-wien commented Jan 5, 2024 •

edited

thib-wien commented Jan 15, 2024 •

edited

Eisei24 left a comment

thib-wien commented Jan 16, 2024 •

edited

Eisei24 left a comment

thib-wien commented Jan 23, 2024

(BIDS-2841) Displaying amounts in the currency that the user selected #2770

Are you sure you want to change the base?

(BIDS-2841) Displaying amounts in the currency that the user selected #2770

Conversation

thib-wien commented Dec 13, 2023 • edited

Eisei24 left a comment

Choose a reason for hiding this comment

Eisei24 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thib-wien Jan 23, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thib-wien Jan 22, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thib-wien Jan 5, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thib-wien commented Jan 5, 2024 • edited

thib-wien commented Jan 15, 2024 • edited

Eisei24 left a comment

Choose a reason for hiding this comment

thib-wien commented Jan 16, 2024 • edited

Eisei24 left a comment

Choose a reason for hiding this comment

thib-wien commented Jan 23, 2024

thib-wien commented Dec 13, 2023 •

edited

thib-wien Jan 23, 2024 •

edited

thib-wien Jan 22, 2024 •

edited

thib-wien Jan 5, 2024 •

edited

thib-wien commented Jan 5, 2024 •

edited

thib-wien commented Jan 15, 2024 •

edited

thib-wien commented Jan 16, 2024 •

edited