(BIDS-2169) return “OK” and all the information a missing slot has #2641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuccaBitfly
requested changes
Oct 30, 2023
|
|
||
| // status 2 = missed slots | ||
| if len(blockInfo.BlockRootHash) != 32 && blockInfo.Status != "2" { | ||
| sendErrorResponse(w, r.URL.String(), "could not retrieve db resultsyy") |
There was a problem hiding this comment.
When trying the endpoint on missed slots the data returned is a huge array consisting of the same slot object, e.g. /api/v1/slot/230431 on Holesky gives me this (5984 elements):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at 8ce3abc
Refactored
handlers/api.goto use ablockInfostruct for block queries. This improves performance and readability of the code.