Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add riscv64 & loong64 for goreleaser #3072

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

znley
Copy link

@znley znley commented Feb 20, 2024

No description provided.

Signed-off-by: znley <shanjiantao@loongson.cn>
Copy link

codecov bot commented Feb 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.38%. Comparing base (bcc7c78) to head (1ea73fe).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3072      +/-   ##
==========================================
- Coverage   19.49%   19.38%   -0.12%     
==========================================
  Files         646      646              
  Lines       54504    54504              
==========================================
- Hits        10625    10565      -60     
- Misses      43340    43411      +71     
+ Partials      539      528      -11     
Flag Coverage Δ
codegen-oldstable-canary-fixtures ?
codegen-stable-canary-fixtures ?
unit-oldstable 82.80% <ø> (+<0.01%) ⬆️
unit-stable 19.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fredbi
Copy link
Contributor

fredbi commented Feb 27, 2024

@znley I don't think we actually use goreleaser for our release process (a pity I'd say, but that's the way it is now).
believe tha the goreleaser config is a remnant of a past attempt to use goreleaser.

@znley
Copy link
Author

znley commented Feb 27, 2024

@fredbi
Now I get it! So what method is used now for release?

@fredbi
Copy link
Contributor

fredbi commented Feb 27, 2024

I believe that is the tool used by @casualjim to cut releases: https://github.com/go-openapi/github-release

@znley
Copy link
Author

znley commented Feb 28, 2024

@fredbi @casualjim
The github-release seems to be used for upload binaries and gorelease is used for building, is right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants