fix(codegen): fixed calling order for WithAutoXOrder #3041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@casualjim @youyuanwu I realize that a lot of work about "keeping things ordered" has already been accomplished in swag. I believe this is the way to solve this issue (and many other unreported ones) for good. |
fredbi
force-pushed
the
fix/2949-keep-spec-order
branch
2 times, most recently
from
74ca358
to
13b79e7
Compare
This PR moves the call to WithAutoXOrder _before_ we validate and flatten the spec for codegen purpose. * fixes go-swagger#2949 Other changes: * layout: moved all the spec massaging to a dedicated source * allowed WithAutoXOrder to report about errors rather than panicking Overall, WithAutoXOrder is simplistic and could be improved a lot: * supporting JSON * supporting remote $refs, circular $refs * removing the dependency to yaml.v2 * not producing a temporary file that hangs around * etc These improvements are beyond the scope of this PR, which is just to fix responses. Perhaps a follow up could bring a more general solution to this problem. Signed-off-by: Frédéric BIDON <fredbi@yahoo.com>
Signed-off-by: Frédéric BIDON <fredbi@yahoo.com>
fredbi
force-pushed
the
fix/2949-keep-spec-order
branch
from
13b79e7
to
a381382
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the call to WithAutoXOrder before we validate and flatten the spec for codegen purpose.
Other changes:
Overall, WithAutoXOrder is simplistic and could be improved a lot:
These improvements are beyond the scope of this PR, which is just to fix responses. Perhaps a follow up could bring a more general solution to this problem.