Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2783 #2955

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix #2783 #2955

wants to merge 2 commits into from

Conversation

rwwiv
Copy link

@rwwiv rwwiv commented Jul 18, 2023

From #2784

This PR attempts to fix #2783 where duplicate struct names were handled incorrectly. This may only be a partial fix, please provide feedback.

Reopening this as-is, tests are currently failing with this change which needs to be fixed before this is ready for review.

code from go-swagger@5905b47

Signed-off-by: William Wernert <william.wernert@grafana.com>
@casualjim
Copy link
Member

thanks, I think this looks good. We do something similar on the codegeneration side

@EugeneWImprint
Copy link

Hi! Is there any update on this? It seems like go-swagger still has issues handling duplicate struct names across different packages

@fredbi fredbi added scanner generate spec Related to spec generation from code labels Jan 9, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (4aff943) 82.64% compared to head (664e9c7) 32.47%.
Report is 1 commits behind head on master.

Files Patch % Lines
codescan/schema.go 0.00% 36 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2955       +/-   ##
===========================================
- Coverage   82.64%   32.47%   -50.18%     
===========================================
  Files          62       60        -2     
  Lines       12856    12836       -20     
===========================================
- Hits        10625     4168     -6457     
- Misses       1692     8329     +6637     
+ Partials      539      339      -200     
Flag Coverage Δ
codegen-oldstable-canary-fixtures 32.47% <0.00%> (-0.09%) ⬇️
codegen-stable-canary-fixtures 32.47% <0.00%> (-0.09%) ⬇️
unit-oldstable ?
unit-stable ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generate spec Related to spec generation from code scanner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Models get mixed when using structs from several packages
4 participants