Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix WithEnum pass []any as any in variadic function, by asasalint #2798

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alingse
Copy link

@alingse alingse commented Jul 4, 2022

see https://github.com/alingse/asasalint for detail

asasalint ./...

got

go-swagger/codescan/responses.go:85:21: pass []any as any to func(values ...interface{}) *github.com/go-openapi/spec.Header
go-swagger/codescan/application_test.go:159:65: pass []any as any to func(t github.com/stretchr/testify/assert.TestingT, expected interface{}, actual interface{}, msgAndArgs ...interface{}) bool
...

ignore the _test.go file, found one place WithEnum(values)

but I don't know it was a mistake or by design ?

Signed-off-by: alingse <alingse@foxmail.com>
@alingse
Copy link
Author

alingse commented Jul 4, 2022

@casualjim need review

@alingse
Copy link
Author

alingse commented Jul 5, 2022

continuous-integration/appveyor/pr — AppVeyor build failed
this seems failed in master too

@alingse
Copy link
Author

alingse commented Jul 8, 2022

@casualjim the CI failed looks like the generates Schema.Allof is an array, so many pr test failed.

@casualjim
Copy link
Member

Thanks. I'll look into why the windows builds started failing again

@fredbi fredbi added scanner generate spec Related to spec generation from code labels Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d1774f8) 82.76% compared to head (45e3ad7) 82.76%.
Report is 164 commits behind head on master.

Files Patch % Lines
codescan/responses.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2798   +/-   ##
=======================================
  Coverage   82.76%   82.76%           
=======================================
  Files          57       57           
  Lines        9732     9732           
=======================================
  Hits         8055     8055           
  Misses       1149     1149           
  Partials      528      528           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generate spec Related to spec generation from code scanner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants