Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement gitlab release webhook #174

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

xNok
Copy link
Contributor

@xNok xNok commented Jun 13, 2023

@coveralls
Copy link

coveralls commented Jun 13, 2023

Coverage Status

coverage: 88.742% (+0.05%) from 88.697% when pulling 4766a27 on xNok:impl-gitlab-release into 2d5aa68 on go-playground:master.

Copy link
Member

@robinlieb robinlieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, could you please revert the mentioned changes?

gitlab/gitlab_test.go Outdated Show resolved Hide resolved
gitlab/gitlab_test.go Outdated Show resolved Hide resolved
gitlab/gitlab_test.go Outdated Show resolved Hide resolved
gitlab/gitlab_test.go Outdated Show resolved Hide resolved
@xNok xNok requested a review from robinlieb October 10, 2023 10:46
@xNok
Copy link
Contributor Author

xNok commented Oct 10, 2023

Sorry kinda forgot about this one, I reverted the indentation changes in the test

@robinlieb robinlieb merged commit 58e552d into go-playground:master Nov 7, 2023
8 checks passed
@robinlieb
Copy link
Member

@xNok Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants