-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added constants for builtin providers #141
base: master
Are you sure you want to change the base?
Conversation
Thank you for the pull request. Unfortunately, it seems that the changes made do not provide the type safety described in the description. Currently, the Generally speaking, this PR is OK as it deduplicates usage of string constants but doesn't do what the PR description says. Please update the description to reflect these changes and address the minor linter issue. Once that has been done, I will be happy to merge the pull request. |
Just added real type safety and fixed the lint issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This really is type-safe, but it breaks back compatibility for all the existing users. The previous method wasn't type-safe but was less destructive. Making such a change will require a new major version, and I see no reason to start v2 just for this thing.
Yes, you are right, this change is not that important to remove the backwards compatibility. Should I left it as it was before (Changing the commit message)? |
yep, just revert it to accept naked string and change the PR description |
Pull Request Test Coverage Report for Build 3877687112
💛 - Coveralls |
Added type safety for builtin providers names