Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test readability: refactored TLS tests #276

Merged
merged 1 commit into from Dec 11, 2023

Conversation

fredbi
Copy link
Member

@fredbi fredbi commented Dec 10, 2023

This PR refactors TLS tests:

  • factorized the clutter of dealing with TLS fixtures (certs, keys, etc)
  • separated ancillary tasks such as initializing a TLS http server and client
  • removed assertions on the deprecated CertPool. The only thing we can do with a CertPool is to verify a certificate against the pool

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Copy link

codecov bot commented Dec 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c6b268) 80.82% compared to head (4f2e629) 80.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #276   +/-   ##
=======================================
  Coverage   80.82%   80.82%           
=======================================
  Files          44       44           
  Lines        3364     3364           
=======================================
  Hits         2719     2719           
  Misses        535      535           
  Partials      110      110           
Flag Coverage Δ
oldstable 80.82% <ø> (ø)
stable 80.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fredbi fredbi merged commit 5e80a92 into go-openapi:master Dec 11, 2023
10 checks passed
@fredbi fredbi deleted the chore/linting-remove-cert-subjects branch December 11, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants