added check to prevent HasContent() to panic after the reader is closed #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredbi
changed the title
casualjim
approved these changes
Dec 8, 2023
youyuanwu
approved these changes
Dec 8, 2023
closed * fixes go-openapi#268 Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #272 +/- ##
==========================================
+ Coverage 80.28% 80.41% +0.12%
==========================================
Files 44 44
Lines 3353 3359 +6
==========================================
+ Hits 2692 2701 +9
+ Misses 546 544 -2
+ Partials 115 114 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also avoids panic in 2 cases:
closing an already closed reader
reading from a closed reader
fixes Panic on runtime@v0.26.0/request.go:99 #268