Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgraded opentelemetry client to OTEL v1.17.0 #271

Merged
merged 1 commit into from Dec 8, 2023

Conversation

fredbi
Copy link
Member

@fredbi fredbi commented Dec 7, 2023

upgraded opentelemetry client to OTEL v1.17.0

  • NOTE: otel v1.17.0 is the last version supporting go1.19.
    more recent otel packages (now v1.21.0) require go1.20.

Signed-off-by: Frederic BIDON fredbi@yahoo.com

@fredbi fredbi changed the title upgraded opentelemetry client to OTEL v1.21.0 upgraded opentelemetry client to OTEL v1.17.0 Dec 7, 2023
@fredbi
Copy link
Member Author

fredbi commented Dec 7, 2023

Notice that with this, runtime won't build with go1.18.

@fredbi fredbi mentioned this pull request Dec 7, 2023
4 tasks
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (381952b) 80.26% compared to head (11f7bec) 80.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
+ Coverage   80.26%   80.28%   +0.01%     
==========================================
  Files          44       44              
  Lines        3350     3353       +3     
==========================================
+ Hits         2689     2692       +3     
  Misses        546      546              
  Partials      115      115              
Flag Coverage Δ
oldstable 80.28% <100.00%> (+0.01%) ⬆️
stable 80.28% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* NOTE: otel v1.17.0 is the last version supporting go1.19.
  more recent otel packages (now v1.21.0) require go1.20.

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@fredbi fredbi merged commit 1d20135 into go-openapi:master Dec 8, 2023
10 checks passed
@fredbi fredbi deleted the upgrade/otel branch December 8, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants