Allow specifying a content type #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the content type header for a multipart file is automatically detected with `http.DetectContentType`. However, sometimes we need to specify a custom content type. This commit provides a simple way to pass a custom content type. If the given `NamedReadCloser` also has a function `ContentType() string`, the returned value will be used. Signed-off-by: Junpei Kawamoto <kawamoto.junpei@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #262 +/- ##
==========================================
+ Coverage 80.20% 80.26% +0.05%
==========================================
Files 44 44
Lines 3350 3350
==========================================
+ Hits 2687 2689 +2
+ Misses 548 546 -2
Partials 115 115
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
youyuanwu
approved these changes
Apr 18, 2023
casualjim
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the content type header for a multipart file is automatically detected with
http.DetectContentType. However, sometimes we need to specify a custom content type.This PR provides a simple way to pass a custom content type. If the given
NamedReadCloseralso has a functionContentType() string, the returned value will be used.