Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove If Exist check on migration for mssql because that syntax required SQL server 2016 (#30894) #30946

Merged
merged 2 commits into from May 12, 2024
Merged

Remove If Exist check on migration for mssql because that syntax required SQL server 2016 (#30894) #30946

merged 2 commits into from May 12, 2024

Conversation

GiteaBot
Copy link
Contributor

Backport #30894 by @lunny

Fix #30872

We will assume the database is consistent before executing the migration. So the indexes should exist. Removing IF EXIST then is safe enough.

@lunny @silverwind @GiteaBot
Remove If Exist check on migration for mssql because that syntax requ…
ae2201d 
…ired SQL server 2016 (go-gitea#30894)

Fix go-gitea#30872

We will assume the database is consistent before executing the
migration. So the indexes should exist. Removing `IF EXIST` then is safe
enough.

---------

Co-authored-by: silverwind <me@silverwind.io>
@GiteaBot GiteaBot added modifies/go Pull requests that update Go code modifies/migrations type/bug labels May 11, 2024
@GiteaBot GiteaBot added this to the 1.22.0 milestone May 11, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 11, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 11, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 11, 2024
@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label May 11, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 12, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 12, 2024
@lunny lunny enabled auto-merge (squash) May 12, 2024 02:48
@lunny lunny merged commit bc45588 into go-gitea:release/v1.22 May 12, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@yp05327 yp05327 yp05327 approved these changes

@wxiaoguang wxiaoguang Awaiting requested review from wxiaoguang

Assignees

@lunny lunny

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/migrations size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GiteaBot @lunny @yp05327