Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JS dependencies, add new eslint rules #30840

Merged
merged 4 commits into from May 10, 2024
Merged

Update JS dependencies, add new eslint rules #30840

merged 4 commits into from May 10, 2024

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented May 2, 2024 •
edited

  • Result of make update-js.
  • Tested build, vue, clipboard copy, swagger ui, citation.
  • Added new eslint rules.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 2, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 2, 2024
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 2, 2024
@silverwind silverwind changed the title Update JS dependencies Update JS dependencies, adjust eslint config May 2, 2024
@silverwind silverwind changed the title Update JS dependencies, adjust eslint config Update JS dependencies, use eslint typescript resolver May 3, 2024
@silverwind
Copy link
Member Author

silverwind commented May 3, 2024 •
edited

I've re-added the main property in package.json for those packages, so in theory it should lint again without a parser change.

https://github.com/silverwind/clippie/blob/1eb353077a67ff3ed02d519d87529a78eb85e529/package.json#L10
https://github.com/silverwind/vite-string-plugin/blob/da1dddcfdf21094c992741c3df59af13eb445258/package.json#L10

@silverwind silverwind marked this pull request as draft May 3, 2024 04:51
@silverwind silverwind marked this pull request as ready for review May 8, 2024 17:29
@silverwind
Copy link
Member Author

Ready again, eslint changes are undone and this now includes a svg regeneration.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 10, 2024
@silverwind silverwind changed the title Update JS dependencies, use eslint typescript resolver Update JS dependencies May 10, 2024
@silverwind
Copy link
Member Author

silverwind commented May 10, 2024 •
edited

Updated once more, apparently svgo has reverted their changes so the svgs are back to original.

@silverwind silverwind changed the title Update JS dependencies Update JS dependencies, add new eslint rules May 10, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 10, 2024
@techknowlogick techknowlogick enabled auto-merge (squash) May 10, 2024 18:48
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 10, 2024
@techknowlogick techknowlogick merged commit 1f3ada4 into go-gitea:main May 10, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone May 10, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 10, 2024
@silverwind silverwind deleted the deps-76 branch May 11, 2024 17:53
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 13, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
ad89474 
* giteaofficial/main:
  [skip ci] Updated licenses and gitignores
  Fix file path width in repo non-homepage view (go-gitea#30951)
  Enable `declaration-block-no-redundant-longhand-properties` (go-gitea#30950)
  [skip ci] Updated translations via Crowdin
  Move reverproxyauth before session so the header will not be ignored even if user has login (go-gitea#27821)
  Use CSS `inset` shorthand (go-gitea#30939)
  Remove If Exist check on migration for mssql because that syntax required SQL server 2016 (go-gitea#30894)
  Update JS dependencies, add new eslint rules (go-gitea#30840)
  Fix some UI regressions for commit list (go-gitea#30920)
  Forbid deprecated `break-word` in CSS (go-gitea#30934)
  Check if reverse proxy is correctly configured (go-gitea#30890)
  Remove deprecated stuff for runners (go-gitea#30930)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/dependencies modifies/internal size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@silverwind @lunny @techknowlogick @GiteaBot