Fix tautological conditions #30735
Merged
Fix tautological conditions #30735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
silverwind
added
the
type/refactoring
silverwind
commented
Apr 27, 2024
silverwind
commented
Apr 27, 2024
silverwind
commented
Apr 27, 2024
|
There's another one at |
delvh
approved these changes
Apr 28, 2024
GiteaBot
added
lgtm/need 1
Fixed in 392a25b by removing the impossible to reach block. |
Draft
|
Two more issues fixed in |
lunny
approved these changes
Apr 30, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
wxiaoguang
reviewed
Apr 30, 2024
| @@ -226,6 +224,10 @@ func ToLabel(label *issues_model.Label, repo *repo_model.Repository, org *user_m | |||
| } | |||
| } | |||
|
|
|||
| if labelBelongsToRepo && repo == nil { | |||
| log.Error("ToLabel did not get repo to calculate url for label with id '%d'", label.ID) | |||
| } | |||
There was a problem hiding this comment.
I still have objection for doing pure-refactoring in this period.
And ideally, it should be like this:
if labelBelongsToRepo {
if repo != nil {
...
} else {
log.Error
}
} else {
if org != nil {
...
} else {
log.Error(...)
}
}
There was a problem hiding this comment.
Those sections are unlikely to be targeted by backports, so I think it's okay. Feel free to raise a PR for that.
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Apr 30, 2024
* origin/main: (55 commits) Fix dashboard commit status null access (go-gitea#30771) Fix tautological conditions (go-gitea#30735) Get repo assignees and reviewers should ignore deactivated users (go-gitea#30770) Right align the "Settings" menu item in overflow-menu (go-gitea#30764) Fix duplicate status check contexts (go-gitea#30660) Fix issue label rendering in the issue popup (go-gitea#30763) Fix all rounded borders, change affected tab menus to pills (go-gitea#30707) Rename CodeIndexerEnabled to IsRepoIndexerEnabled (go-gitea#30762) Remove fomantic dimmer module (go-gitea#30723) Resolve lint for unused parameter and unnecessary type arguments (go-gitea#30750) Add support for npm bundleDependencies (go-gitea#30751) Fix cross-compilation errors when CGO_CFLAGS/CGO_LDFLAGS is set (go-gitea#30749) [skip ci] Updated licenses and gitignores add built js files to eslint ignore (go-gitea#30737) Gitea with first upper case + typos (go-gitea#30739) Fix documentation build problems because of MDX syntax conflicts (go-gitea#30744) Remove disk-clean workflow (go-gitea#30741) Bump `github.com/google/go-github` to v61 (go-gitea#30738) Fix nil dereference on error (go-gitea#30740) Use `ProtonMail/go-crypto` for `opengpg` in tests (go-gitea#30736) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discovered by #30729.