Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fomantic dimmer module #30723

Merged
merged 7 commits into from Apr 29, 2024
Merged

Remove fomantic dimmer module #30723

merged 7 commits into from Apr 29, 2024

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Apr 26, 2024 •
edited

Tested extensively using modal which is the only dependant.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 26, 2024
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 26, 2024
@silverwind silverwind added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Apr 26, 2024
wxiaoguang
wxiaoguang reviewed Apr 27, 2024
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me explain my opinion again and again and again. Defer pure-refactoring work to after a stable release.

@silverwind
Copy link
Member Author

That requires us actual doing some 1.22 releases, we still haven't done any. I see no reason not to merge this now, it is well tested.

@silverwind
Copy link
Member Author

Once the new v1.22 is branched, we can definitely merge this. This won't even be impact any backports.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 28, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 29, 2024
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 29, 2024
@silverwind silverwind enabled auto-merge (squash) April 29, 2024 14:45
@silverwind silverwind merged commit a21ca9b into go-gitea:main Apr 29, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Apr 29, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 29, 2024
@silverwind silverwind deleted the rmdimmer2 branch April 29, 2024 15:03
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 30, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
5c24a90 
* giteaofficial/main:
  Fix duplicate status check contexts (go-gitea#30660)
  Fix issue label rendering in the issue popup (go-gitea#30763)
  Fix all rounded borders, change affected tab menus to pills (go-gitea#30707)
  Rename CodeIndexerEnabled to IsRepoIndexerEnabled (go-gitea#30762)
  Remove fomantic dimmer module (go-gitea#30723)
  Resolve lint for unused parameter and unnecessary type arguments (go-gitea#30750)
  Add support for npm bundleDependencies (go-gitea#30751)
  Fix cross-compilation errors when CGO_CFLAGS/CGO_LDFLAGS is set (go-gitea#30749)
silverwind added a commit to silverwind/gitea that referenced this pull request Apr 30, 2024
@silverwind
Merge remote-tracking branch 'origin/main' into btnrow
3ec0b96 
* origin/main: (55 commits)
  Fix dashboard commit status null access (go-gitea#30771)
  Fix tautological conditions (go-gitea#30735)
  Get repo assignees and reviewers should ignore deactivated users (go-gitea#30770)
  Right align the "Settings" menu item in overflow-menu (go-gitea#30764)
  Fix duplicate status check contexts (go-gitea#30660)
  Fix issue label rendering in the issue popup (go-gitea#30763)
  Fix all rounded borders, change affected tab menus to pills (go-gitea#30707)
  Rename CodeIndexerEnabled to IsRepoIndexerEnabled (go-gitea#30762)
  Remove fomantic dimmer module (go-gitea#30723)
  Resolve lint for unused parameter and unnecessary type arguments (go-gitea#30750)
  Add support for npm bundleDependencies (go-gitea#30751)
  Fix cross-compilation errors when CGO_CFLAGS/CGO_LDFLAGS is set (go-gitea#30749)
  [skip ci] Updated licenses and gitignores
  add built js files to eslint ignore (go-gitea#30737)
  Gitea with first upper case + typos (go-gitea#30739)
  Fix documentation build problems because of MDX syntax conflicts (go-gitea#30744)
  Remove disk-clean workflow (go-gitea#30741)
  Bump `github.com/google/go-github` to v61 (go-gitea#30738)
  Fix nil dereference on error (go-gitea#30740)
  Use `ProtonMail/go-crypto` for `opengpg` in tests (go-gitea#30736)
  ...
@wxiaoguang wxiaoguang mentioned this pull request May 2, 2024
Closed
@wxiaoguang
Copy link
Contributor

Maybe Show modal will cause body width becomeing smaller #30816

@silverwind silverwind mentioned this pull request May 2, 2024
Closed
wxiaoguang
wxiaoguang reviewed May 2, 2024
View reviewed changes
web_src/js/modules/fomantic/dimmer.js
if (arg0 === 'add content') {
const existingDimmer = document.querySelector('body > .ui.dimmer');
if (existingDimmer) {
queryElemChildren(existingDimmer, '*', (el) => el.remove());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change doesn't seem right.

Copy link
Member Author

@silverwind silverwind May 2, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well we definitely need to remove any previous modals otherwise two would show with the append below. Ideally it would put the modals back to their original position in the DOM, but I found no easy way to do that and it works find with this method.

@silverwind silverwind mentioned this pull request May 2, 2024
Merged
lunny pushed a commit that referenced this pull request May 3, 2024
@silverwind @wxiaoguang
Fix body margin shifting with modals, fix error on project column edit (
b30b7df 
#30831)

Fixes: #30816, regression from
#30723.
Fixes: #30815, regression from
#30723.

Fomantic [expects a
callback](https://github.com/fomantic/Fomantic-UI/blob/59d9b409879ad9413ea0a3efa4ab2e51017ad9b9/src/definitions/modules/modal.js#L530-L534)
to be called during `hide` which we did not do, so it could never remove
the margin it added to `body`.

I do observe the body content shifting to right by 1px when modal opens,
but this is a bug that existed on v1.21 as well, so not a regression.

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/js size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@silverwind @wxiaoguang @delvh @GiteaBot