Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set page bottom padding to --page-spacing #30692

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

silverwind
Copy link
Member

Previously we would always leave 80px space before the page footer, but this is problematic with small viewport heights on projects page for example. I think it' ideal that we use --page-spacing which is already in use for spacing on top of the page.

The secondary-nav margin is also adjusted as I see no value why this shouldn't be the same value.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 24, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 24, 2024
@silverwind silverwind changed the title Set page bottom padding to --page-spacing Set page bottom padding to --page-spacing Apr 24, 2024
@lunny
Copy link
Member

lunny commented Apr 25, 2024

Why not 80px? I'm suitable to have more space. Too little space makes me feel stressful.

@silverwind
Copy link
Member Author

silverwind commented Apr 25, 2024

Take for example project view on small viewport height:

image

In this case, a third of the height is wasted by this empty space. With 16px, the space is used much more efficiently:

image

Not sure how common such viewport heights are but I often see this problem when I have DevTools open.

@silverwind
Copy link
Member Author

Likely should use a new variable like --page-margin-y or --page-margin-bottom.

@lunny
Copy link
Member

lunny commented Apr 25, 2024

Take for example project view on small viewport height:
image

In this case, a third of the height is wasted by this empty space. With 16px, the space is used much more efficiently:
image

Not sure how common such viewport heights are but I often see this problem when I have DevTools open.

I personally don't think they are a waste. I like the first one. I like the relaxed feeling. Maybe --page-margin-bottom is a better name.

@silverwind silverwind marked this pull request as draft April 25, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants