Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary code #30665

Closed
wants to merge 1 commit into from
Closed

Remove unnecessary code #30665

wants to merge 1 commit into from

Conversation

lunny
Copy link
Member

@lunny lunny commented Apr 23, 2024

No description provided.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Apr 23, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 23, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 23, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Apr 23, 2024
@wxiaoguang
Copy link
Contributor

It doesn't seem right to remove them.

UPDATE could be used to acquire a transaction lock ahead.

It needs more comments, but not removal.

@lunny
Copy link
Member Author

lunny commented Apr 23, 2024

It doesn't seem right to remove them.

UPDATE could be used to acquire a transaction lock ahead.

It needs more comments, but not removal.

There is already a memory lock so that I think they are unnecessary any more. I will add some comments here.

@wxiaoguang wxiaoguang marked this pull request as draft May 4, 2024 03:36
@lunny lunny closed this May 7, 2024
@lunny lunny deleted the lunny/remove_unnecessary_code branch May 7, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lunny @wxiaoguang @GiteaBot