Fix duplicate status check contexts

[Zettat123]

Caused by #30076.

There may be some duplicate status check contexts when setting status checks for a branch protection rule. The duplicate contexts should be removed.

Before:

After:

[wxiaoguang]

It doesn't seem right.

Think about a case (index, context) in which all the records satisfy "updated_unix":

100, context1
100, context2
101, context3

Your SQL gets all 3 contexts, but only context3 should be used because it is the last.

[Zettat123]

Your SQL gets all 3 contexts, but only context3 should be used because it is the last.

Since the title of the list is "Status checks found in the last week for this repository", I think we should show all unique contexts whose updated_unix is in the last week. So maybe we should show the context[1-3] in the case you mentioned?

[wxiaoguang]

But for all cases, a new status check should override an old one? Why it should show an outdated status context1 to users?

(updated: not related to failure or success)

[Zettat123]

But for all cases, a new status check should override an old one? Why it should show an outdated status context1 to users?

I see. I guess now I understand the case.

For example, I initially had two contexts: test/front and test/back. In commit bbbb, I modified the workflow files and rename the two contexts to test/frontend and test/backend.

index	context	sha	updated_unix
1	test/front	aaaa	1711600000
2	test/back	aaaa	1711600000
1	test/frontend	bbbb	1711600100
2	test/backend	bbbb	1711600100

If now I call the function, I should only get test/frontend and test/backend. Do I understand correctly?

[wxiaoguang]

Yup, I think so

[Zettat123]

I agree that we shouldn't show contexts that no longer exist, but after some testing I found that it's not easy to do so.

In the previous example, I renamed two contexts. Then if I rerun the first two jobs, the records become:

index	context	sha	updated_unix
1	test/front	aaaa	1711600000
2	test/back	aaaa	1711600000
1	test/frontend	bbbb	1711600100
2	test/backend	bbbb	1711600100
3	test/front	aaaa	1711600200
4	test/back	aaaa	1711600200

In this case, it's difficult to determine which contexts are the most recent. Since the contexts displayed in the list are only for reference, I think here we can show all the unique contexts and let users determine which contexts should be matched.

[wxiaoguang]

No idea whether it is good enough. Approve without really checking.

[GiteaBot]

I was unable to create a backport for 1.21. @Zettat123, please send one manually. 🍵

go run ./contrib/backport 30660
...  // fix git conflicts if any
go run ./contrib/backport --continue