Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add project board choice option on issue sidebar #30617

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

add project board choice option on issue sidebar #30617

wants to merge 5 commits into from

Conversation

a1012112796
Copy link
Member

example:
test

@a1012112796
add project board choice option on issue sidebar
6524bd5 
Signed-off-by: a1012112796 <1012112796@qq.com>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 20, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 20, 2024
@github-actions github-actions bot added modifies/translation modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/js labels Apr 20, 2024
@lunny lunny added this to the 1.23.0 milestone Apr 22, 2024
@lunny
Copy link
Member

lunny commented Apr 23, 2024

A change comment need to be created when switching successfully.

lunny
lunny reviewed Apr 23, 2024
View reviewed changes
models/project/board.go Outdated Show resolved Hide resolved
lunny
lunny reviewed Apr 23, 2024
View reviewed changes
models/project/issue.go Outdated Show resolved Hide resolved
@a1012112796
Copy link
Member Author

A change comment need to be created when switching successfully.

That's another feature which is out of the topic of current pull request...

@a1012112796
remove not used code
9207a4e 
Signed-off-by: a1012112796 <1012112796@qq.com>
@lunny
Copy link
Member

lunny commented Apr 23, 2024

A change comment need to be created when switching successfully.

That's another feature which is out of the topic of current pull request...

No, I don't think so. It should be created with the same database transaction.

@a1012112796 a1012112796 mentioned this pull request Apr 25, 2024
Closed
@a1012112796
Copy link
Member Author

A change comment need to be created when switching successfully.

That's another feature which is out of the topic of current pull request...

No, I don't think so. It should be created with the same database transaction.

see #30703, it's not a small change like what you see...

@lunny lunny mentioned this pull request Apr 26, 2024
Merged
7 tasks
@yp05327
Copy link
Contributor

yp05327 commented Apr 30, 2024

Considering multi project support, maybe using modal later is a good choice.

@lunny lunny mentioned this pull request May 7, 2024
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny left review comments

Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/go Pull requests that update Go code modifies/js modifies/templates This PR modifies the template files modifies/translation size/L Denotes a PR that changes 100-499 lines, ignoring generated files. topic/projects
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@a1012112796 @lunny @yp05327 @GiteaBot