Improve attachment upload methods #30513
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
silverwind
reviewed
Apr 17, 2024
| const fileName = file.name.slice(0, file.name.lastIndexOf('.')); | ||
| const fileText = `\\[${fileName}\\]\\(/attachments/${file.uuid}\\)`; | ||
| editor.value(editor.value().replace(new RegExp(`<img [\\s\\w"=]+ alt="${fileName}" src="/attachments/${file.uuid}">`, 'g'), '').replace(new RegExp(`\\!${fileText}`, 'g'), '').replace(new RegExp(fileText, 'g'), '')); | ||
| } |
There was a problem hiding this comment.
Use https://github.com/sindresorhus/escape-string-regexp here, later to be replaced with https://github.com/tc39/proposal-regex-escaping.
Also, this function should have some unit tests.
silverwind
reviewed
Apr 17, 2024
silverwind
reviewed
Apr 17, 2024
| dz.emit('addedfile', attachment); | ||
| dz.emit('thumbnail', attachment, imgSrc); | ||
| if (/\.(jpg|jpeg|png|gif|bmp|svg)$/i.test(attachment.name)) { |
There was a problem hiding this comment.
Try to get the mime type into here and use it instead.
There was a problem hiding this comment.
The attachment variable has no type attribute. This information is obtained from the database. The database does not record the file type.
There was a problem hiding this comment.
There is a typesniffer package in the backend that returns the mime type based on filename. Possible to use here?
gitea/modules/typesniffer/typesniffer.go
Line 85 in d1ba5f4
silverwind
reviewed
Apr 17, 2024
silverwind
reviewed
Apr 17, 2024
Co-authored-by: silverwind <me@silverwind.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #20130
And add a method to drag and drop files to the text area
Can anyone help with testing and review?