Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance improvements for pull request list API #30490

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Performance improvements for pull request list API #30490

wants to merge 19 commits into from
+234 −121

Conversation

lunny
Copy link
Member

@lunny lunny commented Apr 15, 2024

Fix #30483

@lunny lunny added modifies/api This PR adds API routes or modifies them performance/speed performance issues with slow downs labels Apr 15, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 15, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 15, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Apr 15, 2024
@lunny lunny added this to the 1.23.0 milestone Apr 15, 2024
@yp05327
Copy link
Contributor

yp05327 commented Apr 16, 2024

Does web side have same issue?

@lunny
Copy link
Member Author

lunny commented Apr 16, 2024

Does web side have same issue?

I don't think web router of issue/pulls has the same issue.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 29, 2024
yp05327
yp05327 reviewed Apr 30, 2024
View reviewed changes
models/issues/assignees.go Outdated Show resolved Hide resolved
yp05327
yp05327 reviewed May 8, 2024
View reviewed changes
models/issues/pull_list.go Outdated Show resolved Hide resolved
yp05327
yp05327 reviewed May 8, 2024
View reviewed changes
routers/api/v1/repo/pull.go Outdated Show resolved Hide resolved
@yp05327
Copy link
Contributor

yp05327 commented May 8, 2024

image
LoadLabels can be moved to L64-L66?

yp05327
yp05327 reviewed May 8, 2024
View reviewed changes
models/issues/issue_list.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yp05327 yp05327 yp05327 left review comments

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code performance/speed performance issues with slow downs size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

Performance issue on pulls list API endpoint with lots of PR's
4 participants
@lunny @yp05327 @silverwind @GiteaBot