Encrypt OAuth2 Client Secret in db with SecretKey #30482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
lunny
approved these changes
Apr 15, 2024
GiteaBot
added
lgtm/need 1
added 2 commits
April 15, 2024 10:00
|
I would suggest to have a complete secret rotation solution before merge this one. There are too many legacy problem for the secret system, continue using it would cause more problems. A complete secret rotation solution could be like this: each secret key has a version, EncryptSecret should return the version with encrypted content. |
|
But this could be quick fix which will not affect the whole design. |
|
But is the approach stable enough? For example, if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OAuth2 Client Secret is currently stored in plaintext in the db.
This PR encrypts them with the setting.SecretKey.
(similar in changes to #15547)
Changing the SECRET_KEY in the app.ini will now cause these passwords to become unreadable.