dump command on windows works NOT correct

[c-key]

• Gitea version (or commit ref): 1.6.1 and 1.6.3
• Git version: 2.20.0
• Operating system: Windows Server 2016
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log:

C:\GIT>gitea.exe dump --config C:\Git\gitea\custom\conf\app.ini
2019/01/16 16:22:24 Creating tmp work dir: C:\Users\ADMKAH~1\AppData\Local\Temp\2\gitea-dump-660525307
2019/01/16 16:22:24 Dumping local repositories...C:\GIT\repos
2019/01/16 16:22:27 Dumping database...
2019/01/16 16:22:28 Packing dump files...
2019/01/16 16:22:28 Custom dir C:/GIT/custom doesn't exist, skipped
2019/01/16 16:22:28 Packing data directory...C:/GIT/gitea/data
2019/01/16 16:22:30 Removing tmp work dir: C:\Users\ADMKAH~1\AppData\Local\Temp\2\gitea-dump-660525307
2019/01/16 16:22:30 Finish dumping in file gitea-dump-1547652148.zip

Description

I want to update the Gitea version and follow the update guide in the docs. So I create a backup through the dump command and two things does not work correct.

1. The dump command skipped the custom directory. Why, it exists and contains data. But no configuration is found on command line and in the app.ini to correct the path for the custom directory.

This is the directory structure:

C:\Git
├───gitea
│   ├───custom
│   │   ├───certs
│   │   └───conf
│   ├───data
│   │   ├───avatars
│   │   └───sessions
│   ├───indexers
│   │   └───issues.bleve
│   ├───log
│   └───public
└───repos

2. The gitea-repo.zip has a size of 21.632 KB but when I open this file in the windows explorer it showns no content. But in 7-Zip I can see content. Maybe it is the same error like issue gitea dump creates zip with backslashes as path separator #3585.

Please fix the issues. Thanks.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

[T100D]

Same problem here:

Latest version of gitea (1.9.3), dump creates a 1kb file with nothing in it.

c:\gitea>gitea.exe dump --config c:\gitea\custom\conf\app.ini
2019/09/24 16:50:52 ...dules/setting/git.go:83:newGit() [I] Git Version: 2.21.0, Wire Protocol Version 2 Enabled

[T100D]

It works after stopping the service.

[lafriks]

It could be that Gitea can not read files that are already open in Windows and I don't know what can be done here

[yp05327]

You can not see files in windows explorer, because it is rubbish..... Maybe it would be better after windows 11 23H2.
And I think custom data should be backported by user, not Gitea.