Description for issues.ref_closing_from ambiguous and incorrectly localized

[qwertfisch]

• Gitea version (or commit ref): 1.12.3
• Git version:
• Operating system:
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log gist:

Description

After a pull request is added by a user and linked to an issue, the following reference is then described in the given format:

user referenced a pull request that will close this issue time of reference

A specific example would be:

qwertfisch referenced a pull request that will close this issue 1 week ago

Ways of reading

1. The meaning of it, as I understand, is that a user has referenced a pull request 1 week ago, and this pull request will (at some other time in the future) close this issue.
2. But the actual reading tells me that a user referenced a pull request, and this pull request will close this issue 1 week ago (which doesn’t make any sense, at least for me).

This is quite ambiguous. Even more so in German, which clearly is translated unambiguously by the second form (considering the position of the comma and the date inside the subordinate clause).

qwertfisch hat auf einen Pull Request verwiesen, welcher das Issue vor 1 Woche schließen wird

Unfortunately English does not enforce commas and also puts the date at the end of the sentence.

Screenshots

Possible solution

I am not sure if this is a definitive bug or just an ambiguous way of reading (for English). At least the German translation should be changed to not represent the second form semantically.

An umambiguous reading could be something like this:

qwertfisch has referenced a pull request 1 week ago, that will close this issue

This way only the part “has referenced a pull request” can be an href link, not the text “that will close this issue” after the date. This behaviour is already present at the incorrect German translation, where “schließen wird” (after the date) is just text, not an href.

[6543]

solution: fix template to: add a check if time is in the past ... if true, use new translation strings <- has to be added

[qwertfisch]

The date will always be in the past because it references the date when the pull request was added.

[6543]

oh missed that ... then it's easy: fix the english translation by creating a pull and the rest is done via crowdin

[ivanvc]

Rather than changing the ordering of the words, I think a good solution would be maybe adding a hyphen before the time of reference.

i.e.

user referenced a pull request that will close this issue – time of reference
qwertfisch referenced a pull request that will close this issue – 1 week ago

But then, this will mean that many actions that have the time reference at the end would need an update, not just the reference to the pull request. Does this sound like something feasible? I can do the PR to address this. Just want to know this sounds like the correct decision (cc. @6543)

[zeripath]

I think adding an em-dash — (U+2014) (not hyphen) would be a good idea

[eneuschild]

I've been thinking the same thing as @ivanvc. The English version is ambiguous, yes, but not a bad wording per se. Visually setting off the date string rather than incorporating it into the sentence looks to me like a good way to resolve the ambiguity and also make sure that date strings can be at the end of the message in all languages alike.

I have also suggested a correction of the faulty German translation on Crowdin, which still needs to be reviewed there. Let's see how quick they are. ;)

[ivanvc]

I'm hesitating about this change... If the localization has an em-dash, then it will be inconsistent with the text from other events on the issues and pull requests pages.

It immediately looks inconsistent with the header of the comment:

Perhaps a better solution would be to standardize the colors from the strings in the actions section with the rest of them? I think it looks fine and helps differentating the timestamp from the actual text, i.e.:

And the rest of the events even in issues could benefit from this:

[eneuschild]

I'm hesitating about this change... If the localization has an em-dash, then it will be inconsistent with the text from other events on the issues and pull requests pages.

True, if we only change it for this message.
But what if we apply this to all event texts?

[ivanvc]

That was what I initially was doing, changing it from all the event texts. However, I noticed that it looked somewhat incosistent with the text from the section headers. I guess there are two improvements here. One is to standardize the style across those texts, and another is to add the dash to the localization files.